Differential D37453

net-mgmt/netdata: Enable CLOUD option by default
ClosedPublic
Actions

Authored by woodsb02 on Nov 21 2022, 2:19 PM.

Details

Reviewers

Commits

R11:b02e58aec16f: net-mgmt/netdata: Enable CLOUD option by default

Summary

net-mgmt/netdata: Enable CLOUD option by default

Test Plan

poudriere testport works ok on 13.1amd64
I am also running the port with this enable, and can integrate a node
into the cloud platform https://app.netdata.cloud/ by running the
netdata-claim.sh script that is installed with the CLOUD option enabled.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 48438
Build 45324: arc lint + arc unit

Event Timeline

woodsb02 created this revision.Nov 21 2022, 2:19 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 21 2022, 2:19 PM

woodsb02 requested review of this revision.Nov 21 2022, 2:19 PM

Harbormaster completed remote builds in B48438: Diff 113379.Nov 21 2022, 2:19 PM

This should be a flavor rather than default?

In D37453#851587, @diizzy wrote:

This should be a flavor rather than default?

I’m not sure why - just because the cloud option is enabled at compile time doesn’t mean that it automatically integrates with the cloud when it’s first run. This is still a manual step using the netdata-claim.sh script. It also doesn’t add a large suite of dependencies. So why not just have it compiled it by default?

ping @nc - any thoughts on this proposed change to the default options of the net-mgmt/netdata port?

This revision was not accepted when it landed; it landed in state Needs Review.Dec 27 2022, 1:04 AM

Closed by commit R11:b02e58aec16f: net-mgmt/netdata: Enable CLOUD option by default (authored by woodsb02). · Explain Why

This revision was automatically updated to reflect the committed changes.

woodsb02 added a commit: R11:b02e58aec16f: net-mgmt/netdata: Enable CLOUD option by default.