Page MenuHomeFreeBSD

sysutils/polkit: Update to 122
ClosedPublic

Authored by duchateau.olivier_gmail.com on Oct 26 2022, 5:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 9:05 AM
Unknown Object (File)
Sat, Dec 7, 9:05 AM
Unknown Object (File)
Thu, Dec 5, 10:21 PM
Unknown Object (File)
Thu, Dec 5, 10:01 PM
Unknown Object (File)
Wed, Dec 4, 12:28 PM
Unknown Object (File)
Tue, Nov 26, 11:24 AM
Unknown Object (File)
Nov 20 2024, 3:42 AM
Unknown Object (File)
Oct 30 2024, 6:45 PM

Details

Summary
  • Update to 122 (based on D35825)
  • Add DUKTAPE (set by default) and SPIDERMONKEY options
  • Add support of procctl(2) in pkexec program

Tested with 2 differents desktop environment, Pantheon and Budgie. Both have polkit agents (dialog box is displayed without crash).

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

In Makefile there are 2 URLs for MASTER_SITES, because tarball is not (yet) available for the first.

Moin moin

Have you been using it with ducktape for a while yourself?

mfg Toibas

Personally I've been dogfooding, albeit an earlier version, with duktape, and so far some rather important (sub-)commands have crashed. Need to examine more, though with this version.

Moin moin

Have you been using it with ducktape for a while yourself?

mfg Toibas

Yes, since the previous release (121).

Personally I've been dogfooding, albeit an earlier version, with duktape, and so far some rather important (sub-)commands have crashed. Need to examine more, though with this version.

Which command? I use 2 desktops environment (Pantheon and Budgie) both have polkit agent, and I have no crash. Even when I simply run pkexec, dialog box appears.

Personally I've been dogfooding, albeit an earlier version, with duktape, and so far some rather important (sub-)commands have crashed. Need to examine more, though with this version.

Which command? I use 2 desktops environment (Pantheon and Budgie) both have polkit agent, and I have no crash. Even when I simply run pkexec, dialog box appears.

Macro stlgtm:

sysutils/polkit/files/patch-src_programs_pkexec.c
2

this looks upstreamable

Which command? I use 2 desktops environment (Pantheon and Budgie) both have polkit agent, and I have no crash. Even when I simply run pkexec, dialog box appears.

It was pkexec crashing.

Below a screenshot of polkit agent in action with the Pantheon desktop

$ pkg query '%Ok → %Ov' polkit                          
DUKTAPE → on
MANPAGES → off
SPIDERMONKEY → off

polkit-agent.png (768×1 px, 253 KB)

I have just submitted 2 merge requests to upstream:

I have just submitted 2 merge requests to upstream:

very nice :)

Did a few tests so far:

  • Actions in Plasma5 start menu are present and work
  • kexec in running plasma session works as expected (tested with and without group wheel and the simple default polkit.addAdminRule)
  • same without a desktop (ck-launch-session fvwm3) and manually running polkit-kde-authentication-agent-1
  • No luck without the KDE agent (fallback to pkttyagent), authorization is always refused in that case, but maybe I'm doing something wrong?

It's good to update to 122 and find a way to move out of lang/spidermonkey91.
OPTIONS is good, but FLAVORS will be better in this case: there're two separate packages, so it's possible to choose a flavor.

In D37137#862416, @osa wrote:

It's good to update to 122 and find a way to move out of lang/spidermonkey91.
OPTIONS is good, but FLAVORS will be better in this case: there're two separate packages, so it's possible to choose a flavor.

That would make depending on it quite horrible :)

SpiderMonkey not needed at all :) Less rust-based bloatware -- faster builds :)

This revision was not accepted when it landed; it landed in state Needs Review.Jan 6 2023, 2:01 PM
This revision was automatically updated to reflect the committed changes.