Page MenuHomeFreeBSD

zlib crc32: Add prototypes for recently-added static functions.
ClosedPublic

Authored by jhb on Sep 27 2022, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 9 2024, 5:50 AM
Unknown Object (File)
Dec 31 2023, 12:41 PM
Unknown Object (File)
Dec 7 2023, 2:32 PM
Unknown Object (File)
Sep 19 2023, 11:03 AM
Unknown Object (File)
Aug 26 2023, 8:12 PM
Unknown Object (File)
Aug 26 2023, 7:54 PM
Unknown Object (File)
Aug 26 2023, 7:37 PM
Unknown Object (File)
Aug 26 2023, 5:53 PM
Subscribers
None

Details

Summary

This appeases -Wstrict-prototypes with GCC. Using a separate
prototype using the OF macro seems to be consistent with the rest of
this file which still supports pre-ANSI C.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:42 PM
jhb created this revision.

Should these also be upstreamed?

This revision is now accepted and ready to land.Sep 27 2022, 6:17 PM

There's a bigger question of what to do w/ zlib upstream with K&R, so it seems fine to make this change in our tree now and separately try to tackle all of that together.