Page MenuHomeFreeBSD

zlib crc32: Add prototypes for recently-added static functions.
ClosedPublic

Authored by jhb on Sep 27 2022, 5:42 PM.
Tags
None
Referenced Files
F166439895: D36755.id111149.diff
Thu, Aug 13, 2:18 PM
F166322892: D36755.diff
Wed, Aug 12, 10:01 PM
Unknown Object (File)
Wed, Aug 12, 1:13 PM
Unknown Object (File)
Wed, Aug 12, 8:30 AM
Unknown Object (File)
Wed, Aug 12, 3:46 AM
Unknown Object (File)
Wed, Aug 12, 12:28 AM
Unknown Object (File)
Tue, Aug 11, 11:39 PM
Unknown Object (File)
Tue, Aug 11, 11:38 AM
Subscribers
None

Details

Summary

This appeases -Wstrict-prototypes with GCC. Using a separate
prototype using the OF macro seems to be consistent with the rest of
this file which still supports pre-ANSI C.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:42 PM
jhb created this revision.

Should these also be upstreamed?

This revision is now accepted and ready to land.Sep 27 2022, 6:17 PM

There's a bigger question of what to do w/ zlib upstream with K&R, so it seems fine to make this change in our tree now and separately try to tackle all of that together.