Page MenuHomeFreeBSD

zlib crc32: Add prototypes for recently-added static functions.
ClosedPublic

Authored by jhb on Sep 27 2022, 5:42 PM.
Tags
None
Referenced Files
F140943419: D36755.id111097.diff
Mon, Dec 29, 10:39 PM
Unknown Object (File)
Thu, Dec 25, 11:32 AM
Unknown Object (File)
Thu, Dec 18, 11:40 PM
Unknown Object (File)
Nov 24 2025, 8:44 PM
Unknown Object (File)
Nov 18 2025, 8:16 PM
Unknown Object (File)
Nov 13 2025, 3:09 AM
Unknown Object (File)
Nov 6 2025, 9:20 AM
Unknown Object (File)
Nov 6 2025, 9:20 AM
Subscribers
None

Details

Summary

This appeases -Wstrict-prototypes with GCC. Using a separate
prototype using the OF macro seems to be consistent with the rest of
this file which still supports pre-ANSI C.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Sep 27 2022, 5:42 PM
jhb created this revision.

Should these also be upstreamed?

This revision is now accepted and ready to land.Sep 27 2022, 6:17 PM

There's a bigger question of what to do w/ zlib upstream with K&R, so it seems fine to make this change in our tree now and separately try to tackle all of that together.