ntb: Use uintmax_t casts and %j to print physical addresses.
ClosedPublic
Actions

Authored by jhb on Sep 27 2022, 5:35 PM.

Details

Reviewers

mav
imp

Commits

rG54c65cbb2475: ntb: Use uintmax_t casts and %j to print physical addresses.
rG124e46735e07: ntb: Use uintmax_t casts and %j to print physical addresses.

Summary

This fixes -Wint-to-pointer-cast errors with GCC when compiling on
i386 where physical addresses are not the same size as pointers.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Sep 27 2022, 5:35 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 27 2022, 5:35 PM

jhb requested review of this revision.Sep 27 2022, 5:35 PM

Harbormaster completed remote builds in B47566: Diff 111091.Sep 27 2022, 5:35 PM

Times like this that I wish we had a %P in our printf that printed a vm_paddr_t.

This revision is now accepted and ready to land.Sep 27 2022, 6:21 PM

mav accepted this revision.Sep 27 2022, 7:40 PM

Closed by commit rG124e46735e07: ntb: Use uintmax_t casts and %j to print physical addresses. (authored by jhb). · Explain WhySep 28 2022, 9:06 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG124e46735e07: ntb: Use uintmax_t casts and %j to print physical addresses..

jhb added a commit: rG54c65cbb2475: ntb: Use uintmax_t casts and %j to print physical addresses..Nov 11 2022, 6:37 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ntb/

ntb_hw/

ntb_hw_amd.c

6 lines

ntb_hw_intel.c

14 lines

Diff 111146

View Options

sys/dev/ntb/ntb_hw/ntb_hw_amd.c