Page MenuHomeFreeBSD
Differential D36662

audio/spotify-player: Move CARGO_CRATES list to Makefile.crates
ClosedPublic
Actions

Authored by jrm on Sep 21 2022, 10:34 PM.
Tags
None
Referenced Files
F109110809: D36662.id110830.diff
Fri, Jan 31, 10:34 PM
Unknown Object (File)
Wed, Jan 22, 2:34 PM
Unknown Object (File)
Tue, Jan 21, 6:57 PM
Unknown Object (File)
Sun, Jan 12, 10:18 AM
Unknown Object (File)
Dec 27 2024, 4:07 PM
Unknown Object (File)
Dec 3 2024, 4:08 PM
Unknown Object (File)
Nov 24 2024, 4:23 PM
Unknown Object (File)
Nov 23 2024, 2:44 PM
View All 93 Files
Subscribers
eduardo
mat

Details

Reviewers
jfree
Commits
R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates
Summary

Mk/Uses/cargo.mk looks for Makefile.crates in MASTERDIR, so move the
list of CARGO_CRATES there to have a smaller and cleaner Makefile
and to make updates easier with

make cargo-crates > Makefile.crates.

Reported by: eduardo
Approved by: jfree (maintainer)
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm created this revision.Sep 21 2022, 10:34 PM
Herald added a subscriber: mat. · View Herald TranscriptSep 21 2022, 10:34 PM
jrm requested review of this revision.Sep 21 2022, 10:34 PM
Harbormaster completed remote builds in B47481: Diff 110830.Sep 21 2022, 10:34 PM
jfree added a comment.Sep 21 2022, 11:52 PM

Looks good to me. Great solution to clear up the primary Makefile.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2022, 12:05 AM
Closed by commit R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates (authored by jrm). · Explain Why
This revision was automatically updated to reflect the committed changes.
jrm added a commit: R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates.

Revision Contents
Changeset List

PathSize
audio/
spotify-player/
458 lines
57 lines

Diff 110836

View Options

audio/spotify-player/Makefile

Loading...
View Options

audio/spotify-player/Makefile.crates

Loading...