audio/spotify-player: Move CARGO_CRATES list to Makefile.crates
ClosedPublic
Actions

Authored by jrm on Sep 21 2022, 10:34 PM.

Details

Reviewers

Commits

R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates

Summary

Mk/Uses/cargo.mk looks for Makefile.crates in MASTERDIR, so move the
list of CARGO_CRATES there to have a smaller and cleaner Makefile
and to make updates easier with

make cargo-crates > Makefile.crates.

Reported by: eduardo
Approved by: jfree (maintainer)
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrm created this revision.Sep 21 2022, 10:34 PM

Herald added a subscriber: mat. · View Herald TranscriptSep 21 2022, 10:34 PM

jrm requested review of this revision.Sep 21 2022, 10:34 PM

Harbormaster completed remote builds in B47481: Diff 110830.Sep 21 2022, 10:34 PM

Looks good to me. Great solution to clear up the primary Makefile.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 22 2022, 12:05 AM

Closed by commit R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates (authored by jrm). · Explain Why

This revision was automatically updated to reflect the committed changes.

jrm added a commit: R11:2119296169cb: audio/spotify-player: Move CARGO_CRATES list to Makefile.crates.

Revision Contents
Changeset List

Path

Size

audio/

spotify-player/

Makefile

458 lines

	Makefile.crates
	Makefile

57 lines

Diff 110836

View Options

audio/spotify-player/Makefile