Differential D36401

libpmc: pmc_init() should avoid overflowing pmc_class_table
ClosedPublic
Actions

Authored by tsoome on Aug 31 2022, 11:14 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 17, 5:46 AM

	Unknown Object (File)
	Thu, Oct 16, 7:30 PM

	Unknown Object (File)
	Thu, Oct 16, 7:10 PM

	Unknown Object (File)
	Tue, Oct 14, 5:30 PM

	Unknown Object (File)
	Tue, Oct 14, 8:38 AM

	Unknown Object (File)
	Sat, Oct 11, 10:18 PM

	Unknown Object (File)
	Sat, Oct 11, 10:18 PM

	Unknown Object (File)
	Sat, Oct 11, 10:18 PM

Subscribers

Details

Reviewers: None
Commits: rG1f5679569dd4: libpmc: pmc_init() should avoid overflowing pmc_class_table

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Aug 31 2022, 11:14 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 31 2022, 11:14 AM

tsoome requested review of this revision.Aug 31 2022, 11:14 AM

Harbormaster completed remote builds in B47196: Diff 110009.Aug 31 2022, 11:14 AM

commit message update

Harbormaster completed remote builds in B47198: Diff 110011.Aug 31 2022, 11:30 AM

50 enumeration values not handled in switch

Harbormaster completed remote builds in B47199: Diff 110012.Aug 31 2022, 11:44 AM

jrtc27 added a subscriber: jrtc27.Aug 31 2022, 2:39 PM

jrtc27 added inline comments.

lib/libpmc/libpmc.c
1476	Presumably this was a hacky alternative way to write that pm_classes contained a PMC_CLASS_TSC? I imagine this check is now redundant.
1607	Should we have an equivalent of this for the classes case? Also for the ARMV7/8 switches we now have? I guess continuing with the subset libpmc has been taught about is helpful, but silently not getting a set of counters also isn't...

review feedback.

Harbormaster completed remote builds in B47206: Diff 110021.Aug 31 2022, 4:15 PM

tsoome marked an inline comment as done.Aug 31 2022, 4:16 PM

tsoome added inline comments.

lib/libpmc/libpmc.c
1476	I have no idea about the history there, but yea, if the kernel does know about PMC_CLASS_TSC, it makes little sense to filter it out.
1607	Yes, good point.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 5 2022, 12:39 PM

Closed by commit rG1f5679569dd4: libpmc: pmc_init() should avoid overflowing pmc_class_table (authored by tsoome). · Explain Why

This revision was automatically updated to reflect the committed changes.

tsoome marked an inline comment as done.

tsoome added a commit: rG1f5679569dd4: libpmc: pmc_init() should avoid overflowing pmc_class_table.

Revision Contents
Changeset List

Path

Size

lib/

libpmc/

2 lines

108 lines

Diff 110146

lib/libpmc/Makefile

Loading...

lib/libpmc/libpmc.c

Loading...