Page MenuHomeFreeBSD

Mk/Uses: always use colon for build/run suffix
ClosedPublic

Authored by zirias on Aug 25 2022, 3:12 PM.

Details

Summary

Most USES use a colon for build/run(/test) suffixes. Change kde.mk,
qt.mk and pyqt.mk to do the same, and update all ports using that.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 47323
Build 44210: arc lint + arc unit

Event Timeline

Note only Mk/Uses/{kde,qt,pyqt}.mk are changed explicitly, all port Makefiles are just processed by this script:
https://people.freebsd.org/~zirias/scripts/update-use-kde-qt-pyqt.pl.txt

I don't mind whether it is ':' or '_' personally but consistency is nice.

So, please ask for an exp-run.

You can also already prepare an entry for the CHANGES file.

Add CHANGES entry, please let me know whether it would be fine that way.
Of course, concrete date is pending...

Whats the behaviour when you have

USE_QT=foo_build

after the patch, will it properly error out? -- if not, please add some error handling :)

USE_QT=foo_build
after the patch, will it properly error out? -- if not, please add some error handling :)

It will, in *this* case.
But it won't for USE_PYQT, as this is implemented quite diffrerently. For PYQT, '_' would just silently keep working. If that's a problem, I'll have a look at how this could be fixed...

USE_QT=foo_build
after the patch, will it properly error out? -- if not, please add some error handling :)

It will, in *this* case.
But it won't for USE_PYQT, as this is implemented quite diffrerently. For PYQT, '_' would just silently keep working. If that's a problem, I'll have a look at how this could be fixed...

ok, the pyqt.mk fix should be its own review then, as that is an unrelated fix to this (only accepting known values).

Fix pyqt.mk to error out correctly, THANKS @tcberner!

Rebased and (hopefully) fixed after first exp-run.

For reference, rebasing will quickly run into conflicts, so here's how to
re-generate the diff from scratch:

  1. Apply a patch only updating the framework files: https://people.freebsd.org/~zirias/patches/always-use-colon_Mk-only-v2.patch
  1. Run a script from PORTSDIR root to update all affected ports: https://people.freebsd.org/~zirias/scripts/update-use-kde-qt-pyqt-v2.pl.txt

Rebased and regenerated after successful exp-run.

This revision is now accepted and ready to land.Sep 11 2022, 10:07 AM