framework: generalize WITH_ code
ClosedPublic
Actions

Authored by bapt on Jul 21 2022, 10:00 AM.

Details

Reviewers

tcberner

Group Reviewers

portmgr

Commits

R11:b26839acc225: framework: generalize WITH_ code

Summary

Make the definition of WITH_ variable (end user actionable) a define
via a generic code
Move the WITH_DEBUG code into its own file Features/debug.mk
Replace USE_LTO into WITH_LTO and move it into Features/lto.mk
Move WITH_SSP into its own Features/ssp.mk

Add a variable to defined which one are activated by default (here SSP)

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Jul 21 2022, 10:00 AM

Herald added a reviewer: portmgr. · View Herald TranscriptJul 21 2022, 10:00 AM

Herald added a subscriber: mat. · View Herald Transcript

bapt requested review of this revision.Jul 21 2022, 10:00 AM

Harbormaster completed remote builds in B46501: Diff 108388.Jul 21 2022, 10:00 AM

properly indent

Harbormaster completed remote builds in B46502: Diff 108389.Jul 21 2022, 10:13 AM

2khramtsov_gmail.com added a subscriber: 2khramtsov_gmail.com.Jul 21 2022, 1:35 PM

tcberner added a subscriber: tcberner.Jul 27 2022, 12:59 PM

tcberner added inline comments.

Mk/Features/debug.mk
2	^ add documentation on how to use it?
Mk/Features/lto.mk
4	^ this contradicts the warning in bsd.port.mk?
Mk/bsd.port.mk
1308	^why keep the old behavior? Wouldn't it make more sense to just get rid of the old behavior in one go?

I wonder whether ENABLE_FEATURES=[list] and DISABLE_FEATURES=[list] would not be the better API, instead of WITH_${feature}=yes and WITHOUT_${feature}=yes.

address @tcberner remarks

Harbormaster completed remote builds in B46621: Diff 108594.Jul 27 2022, 1:13 PM

bapt marked 2 inline comments as done.Jul 27 2022, 1:14 PM

bapt added inline comments.

Mk/bsd.port.mk
1308	I think we should keep the old behaviour for a couple of month and then turn it into an error for a couple of more month, then remove everything ;)