New Port: devel/erlang-p1xml - Fast Expat based Erlang XML parsing library
Details
Details
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
- Fix PORTVERSION. This programmin is not versioned (yet) and we may use date tag instead
| devel/erlang-p1xml/Makefile | ||
|---|---|---|
| 5 ↗ | (On Diff #8582) | When the date is just a placeholder, you should use, say, 0.date or 0.0.date so that when they end up releasing 1.0 you don't have to bump PORTEPOCH. |
| devel/erlang-p1xml/files/patch-rebar.config.script.in | ||
| 7–10 ↗ | (On Diff #8582) | Can't you not patch that file, and do some more magic in the REINPLACE_CMD lines ? something like: @${REINPLACE_CMD} -e 's|{"CFLAGS", ".*"|{"CFLAGS", "${CFLAGS}"|' \
-e 's|{"LDFLAGS", ".*"|{"LDFLAGS", "${LDFLAGS}"|' ${WRKSRC}/rebar.config.script.inor something. |
| devel/erlang-p1xml/pkg-plist | ||
| 1 ↗ | (On Diff #8582) | No. |
| devel/erlang-p1xml/pkg-plist | ||
|---|---|---|
| 1 ↗ | (On Diff #8582) | We do not set $freeBSD$ in the plist |
| devel/erlang-p1xml/pkg-plist | ||
|---|---|---|
| 1 ↗ | (On Diff #8582) | Something is wrong with the default template in ports-mgmt/porttools. Thanks for pointing out. |
| devel/erlang-p1xml/Makefile | ||
|---|---|---|
| 4 ↗ | (On Diff #8583) | I've been wondering, is there a reason this is not named "xml" like it's GH_PROJECT leads to think it's called ? |
| 6 ↗ | (On Diff #8583) | Shouldn't this be in the textproc category, where all the xml stuff are ? |
| 27 ↗ | (On Diff #8583) | Does this do anything ? I mean, if you still have to strip the only two .so installed by the port, it feels it's not doing anything. |
| 34–35 ↗ | (On Diff #8583) | This could, maybe, be folded into one line, doing: ${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/erlang/lib/${PORTNAME}-${PORTVERSION}/priv/lib/*.so |
| devel/erlang-p1xml/pkg-plist | ||
| 2 ↗ | (On Diff #8583) | There are so many things wrong with porttools :-) |
Comment Actions
- remove unnecessary lines from Makefile
| devel/erlang-p1xml/Makefile | ||
|---|---|---|
| 4 ↗ | (On Diff #8583) | Actually there is already an xml module for erlang, and this module is an alternative that is known as p1xml (all modules from Process1 are named like this). Changing the name to xml will be confusing. |
| 6 ↗ | (On Diff #8583) | Well, all erlang modules reside in ports/devel, such as erlang-exmpp which belongs to net-im. Is it okay to do CATEGORIES= devel textproc? |
| devel/erlang-p1xml/Makefile | ||
|---|---|---|
| 5 ↗ | (On Diff #8586) | Ok, just asking :-) |
| 7 ↗ | (On Diff #8586) | Just because someone was doing stupid things does not give you license to :-) If you look at https://www.freebsd.org/doc/en/books/porters-handbook/makefile-categories.html you'll see that it clearly states not to use devel if they can go elsewhere, in this case, it should go in textproc. |
| textproc/erlang-p1xml/Makefile | ||
|---|---|---|
| 29 ↗ | (On Diff #8587) | This line seems badly indented, but it must be phabricator. (it should start with two tabs.) |