x86/xen: set the ACPI RSDP kenv hint earlier for PVH
AbandonedPublic
Actions

Authored by royger on Jun 28 2022, 4:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 27, 3:18 AM

	Unknown Object (File)
	Sat, Apr 27, 2:48 AM

	Unknown Object (File)
	Sat, Apr 27, 2:02 AM

	Unknown Object (File)
	Jan 10 2024, 2:20 AM

	Unknown Object (File)
	Dec 29 2023, 1:10 PM

	Unknown Object (File)
	Jun 28 2023, 2:08 AM

	Unknown Object (File)
	Jun 17 2023, 1:44 PM

	Unknown Object (File)
	May 6 2023, 4:58 AM

View All 14 Files

Subscribers

imp

Details

Reviewers

cperciva
imp

Summary

When booting using the PVH entry point set the ACPI RSPD hint in kenv
as soon as the static kenv is initialized, there's no reason to delay
setting it.

Reported by: cpercival
Sponsored by: Citrix Systems R&D

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46154
Build 43043: arc lint + arc unit

Event Timeline

royger created this revision.Jun 28 2022, 4:00 PM

Herald added subscribers: ehem_freebsd_m5p.com, imp. · View Herald TranscriptJun 28 2022, 4:00 PM

royger requested review of this revision.Jun 28 2022, 4:00 PM

Harbormaster completed remote builds in B46154: Diff 107484.Jun 28 2022, 4:00 PM

imp accepted this revision.Jun 28 2022, 5:48 PM

This revision is now accepted and ready to land.Jun 28 2022, 5:48 PM

Doesn't help with Firecracker; turns out they don't do ACPI so RSDP is just set to zero there. No objection to the change if you think it will help elsewhere though.

BTW I'm cperciva, not cpercival. ;-)

ehem_freebsd_m5p.com removed a subscriber: ehem_freebsd_m5p.com.Jun 28 2022, 11:26 PM

Nah, I guess there's no need to move it, so I will keep as-is to avoid code churn. Sorry for the alias mess :).

Revision Contents
Changeset List

Path

Size

sys/

x86/

xen/

pv.c

11 lines

Diff 107484

View Options

x86/xen: set the ACPI RSDP kenv hint earlier for PVHAbandonedPublicActions