Page MenuHomeFreeBSD
Differential D35483

XHCI: clear warm and port reset
ClosedPublic
Actions

Authored by bz on Jun 14 2022, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 22, 8:25 PM
Unknown Object (File)
Fri, Mar 22, 8:24 PM
Unknown Object (File)
Feb 24 2024, 1:28 AM
Unknown Object (File)
Feb 6 2024, 6:54 PM
Unknown Object (File)
Jan 14 2024, 9:47 AM
Unknown Object (File)
Dec 30 2023, 6:47 AM
Unknown Object (File)
Dec 22 2023, 12:05 PM
Unknown Object (File)
Dec 20 2023, 4:39 AM
View All 35 Files
Subscribers
imp

Details

Reviewers
• hselasky
Commits
rG66754c01ff95: XHCI: clear warm and port reset
rG8f892e9bee33: XHCI: clear warm and port reset
Summary

It seems we do not clear UPS_C_BH_PORT_RESET and UPS_C_PORT_RESET
conditions after warm or port reset. Add that code.

Obtained from: an older patch used for debugging

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Jun 14 2022, 4:55 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 14 2022, 4:55 PM
bz requested review of this revision.Jun 14 2022, 4:55 PM
Harbormaster completed remote builds in B45974: Diff 106914.Jun 14 2022, 4:55 PM
bz added a comment.Jun 14 2022, 4:56 PM

I have to admit I no longer have a recollection when I did this and what was the cause.
I figured I put it up for review so you can have a look before I'll lose it.

• hselasky added inline comments.Jun 14 2022, 7:43 PM
sys/dev/usb/usb_hub.c
1095

Update this to:
if (err != USB_ERR_NORMAL_COMPLETION)
retval = err;

1104

ditto

bz updated this revision to Diff 106932.Jun 14 2022, 9:29 PM

Good catch! Updated to match current code.

Harbormaster completed remote builds in B45982: Diff 106932.Jun 14 2022, 9:30 PM
bz marked 2 inline comments as done.Jun 14 2022, 9:31 PM
• hselasky accepted this revision.Jun 15 2022, 7:11 AM

Looks good.

This revision is now accepted and ready to land.Jun 15 2022, 7:11 AM
• hselasky added inline comments.Jun 15 2022, 7:14 AM
sys/dev/usb/usb_hub.c
1091

You might want to check if the device is super-speed before doing this.

• hselasky added inline comments.Jun 15 2022, 7:16 AM
sys/dev/usb/usb_hub.c
1091

might -> must, because this bit has different meaning for USB 2.0 !

• hselasky requested changes to this revision.Jun 15 2022, 7:16 AM
This revision now requires changes to proceed.Jun 15 2022, 7:16 AM
• hselasky added inline comments.Jun 15 2022, 7:17 AM
sys/dev/usb/usb_hub.c
1091
if (udev->speed == USB_SPEED_SUPER) {
,...
}
bz updated this revision to Diff 106958.Jun 15 2022, 7:10 PM
bz marked 3 inline comments as done.

Check for SUPER_SPEED on the overloaded bit between USB2/3.

Harbormaster completed remote builds in B45992: Diff 106958.Jun 15 2022, 7:10 PM
• hselasky accepted this revision.Jun 15 2022, 7:14 PM

Looks good.

This revision is now accepted and ready to land.Jun 15 2022, 7:14 PM
Closed by commit rG8f892e9bee33: XHCI: clear warm and port reset (authored by bz). · Explain WhyJun 15 2022, 9:13 PM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG8f892e9bee33: XHCI: clear warm and port reset.
bz added a commit: rG66754c01ff95: XHCI: clear warm and port reset.Jul 1 2022, 2:58 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
usb/
15 lines

Diff 106973

View Options

sys/dev/usb/usb_hub.c

Loading...