Eliminate setgid leftover in w(1).
ClosedPublic
Actions

Authored by delphij on Sep 1 2015, 6:13 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 25, 8:32 AM

	Unknown Object (File)
	Wed, Apr 22, 12:20 AM

	Unknown Object (File)
	Tue, Apr 21, 4:24 PM

	Unknown Object (File)
	Tue, Apr 21, 8:30 AM

	Unknown Object (File)
	Tue, Apr 21, 1:15 AM

	Unknown Object (File)
	Mon, Apr 20, 6:42 AM

	Unknown Object (File)
	Fri, Apr 17, 8:23 AM

	Unknown Object (File)
	Wed, Apr 15, 7:26 PM

View All Files

Subscribers

imp

wollman

Details

Reviewers

peter
wollman

Group Reviewers

security
secteam

Commits

rS287590: w(1) is not setgid binary since r53279, so remove the setgid() call.

Summary

w(1) is not sgid binary since r53279. We should either unconditionally
do setgid() if we are really concerned, or just get rid of the setgid
bits.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

delphij updated this revision to Diff 8380.Sep 1 2015, 6:13 AM

delphij retitled this revision from to Eliminate setgid leftover in w(1)..

delphij updated this object.

delphij edited the test plan for this revision. (Show Details)

delphij added a reviewer: peter.

Herald added a subscriber: imp. · View Herald TranscriptSep 1 2015, 6:13 AM

delphij added reviewers: secteam, security.Sep 1 2015, 6:34 AM

Makes sense to me.

This revision is now accepted and ready to land.Sep 6 2015, 8:28 PM

Closed by commit rS287590: w(1) is not setgid binary since r53279, so remove the setgid() call. (authored by delphij). · Explain WhySep 9 2015, 5:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

Makefile

2 lines

w.c

12 lines

Diff 8618

View Options

head/usr.bin/w/Makefile