pci: make MSI(-X) enable and disable methods of the PCI bus

[royger]

Summary

Make the functions pci_disable_msi, pci_enable_msi and pci_enable_msix
methods of the newbus PCI bus. This code should not include any
functional change.

Sponsored by: Citrix Systems R&D

[imp]

Looks good to me.

[jhb]

Looks fine to me.

[royger]

Update to prevent the newly introduced pci_enable_msix clashing with
the Linux version defined in ofed/include/linux/pci.h.

[royger]

Adding people who worked in ofed in order to review the new bits, I would also like to add hselasky but he doesn't seem to have a phabric account.

Alfred, could you take a look at the ofed bits? I'm introducing a native FreeBSD version of pci_enable_msix which clashes with the Linux compatibility one defined in sys/ofed/include/linux/pci.h.

[jhb]

sys/ofed/include/linux/pci.h

539

One alternate thing you could try would be to add a #define before this function definition that was:

#define pci_enable_msix linux_pci_enable_msix

and then revert the the rest of the ofed related changes. If that works, it might be slightly preferable as it doesn't require modifications in drivers that are using the shim layer, albeit being a bit more gross / fragile.

[royger]

Thanks, committed as r270212.