gcore: Don't hardcode VM write permissions.
ClosedPublic
Actions

Authored by jhb on Jun 3 2022, 9:55 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 22, 7:55 AM

	Unknown Object (File)
	Wed, Sep 16, 8:21 PM

	Unknown Object (File)
	Wed, Sep 16, 6:26 PM

	Unknown Object (File)
	Wed, Sep 16, 3:28 PM

	Unknown Object (File)
	Sun, Sep 6, 3:18 PM

	Unknown Object (File)
	Sun, Sep 6, 2:20 PM

	Unknown Object (File)
	Sun, Sep 6, 10:41 AM

	Unknown Object (File)
	Sun, Sep 6, 2:45 AM

View All Files

Subscribers

imp

Details

Reviewers

markj

Commits

rG4f8a3bb601ad: gcore: Don't hardcode VM write permissions.
rG81c857dd7e6a: gcore: Don't hardcode VM write permissions.

Summary

This ensures read-only PT_LOAD segments are not marked as writable in
the phdr flags.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jun 3 2022, 9:55 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 3 2022, 9:55 PM

jhb requested review of this revision.Jun 3 2022, 9:55 PM

Harbormaster completed remote builds in B45842: Diff 106621.Jun 3 2022, 9:55 PM

markj accepted this revision.Jun 3 2022, 10:03 PM

This revision is now accepted and ready to land.Jun 3 2022, 10:03 PM

Closed by commit rG81c857dd7e6a: gcore: Don't hardcode VM write permissions. (authored by jhb). · Explain WhyJun 6 2022, 11:51 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG81c857dd7e6a: gcore: Don't hardcode VM write permissions..

jhb added a commit: rG4f8a3bb601ad: gcore: Don't hardcode VM write permissions..Jul 13 2022, 4:47 PM

Revision Contents
Changeset List

Path

Size

usr.bin/

gcore/

elfcore.c

4 lines

Diff 106701

View Options

gcore: Don't hardcode VM write permissions.ClosedPublicActions