Page MenuHomeFreeBSD
Differential D35330

bsdinstall: allow a install script to access packages on the DVD
ClosedPublic
Actions

Authored by asomers on May 26 2022, 9:42 PM.
Tags
None
Referenced Files
F132336108: D35330.diff
Thu, Oct 16, 12:36 AM
Unknown Object (File)
Mon, Oct 13, 6:09 AM
Unknown Object (File)
Mon, Oct 13, 1:55 AM
Unknown Object (File)
Mon, Oct 13, 1:55 AM
Unknown Object (File)
Mon, Oct 13, 1:55 AM
Unknown Object (File)
Sun, Oct 12, 2:09 PM
Unknown Object (File)
Fri, Oct 10, 11:35 PM
Unknown Object (File)
Fri, Oct 10, 9:58 PM
View All Files
Subscribers
imp

Details

Reviewers
gjb
Commits
rG504ac101ba28: bsdinstall: allow an install script to access packages on the DVD
rG6a02539959cb: bsdinstall: allow an install script to access packages on the DVD
Summary

If installing from the DVD, mount its packages in the chroot at
/dist/packages. That way they'll be accessible to an install script.

MFC after: 2 weeks
Sponsored by: Axcient

Test Plan

Tested with a custom install script that installs bash

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.May 26 2022, 9:42 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 26 2022, 9:42 PM
asomers requested review of this revision.May 26 2022, 9:42 PM
Harbormaster completed remote builds in B45734: Diff 106407.May 26 2022, 9:42 PM
gjb added inline comments.May 27 2022, 2:08 PM
usr.sbin/bsdinstall/scripts/mount
64

Where does this get umounted? Is that implied but the subsequent change to the scripts/umount script?

asomers added inline comments.May 27 2022, 3:13 PM
usr.sbin/bsdinstall/scripts/mount
64

Exactly. Both bsdinstall auto and bsdintall script will call bsdinstall mount/bsdinstall umount as a pair.

gjb accepted this revision.May 27 2022, 3:21 PM
This revision is now accepted and ready to land.May 27 2022, 3:21 PM
Closed by commit rG6a02539959cb: bsdinstall: allow an install script to access packages on the DVD (authored by asomers). · Explain WhyJun 13 2022, 7:28 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG6a02539959cb: bsdinstall: allow an install script to access packages on the DVD.
asomers added a commit: rG504ac101ba28: bsdinstall: allow an install script to access packages on the DVD.Jul 24 2022, 3:41 PM

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
scripts/
6 lines
7 lines

Diff 106874

View Options

usr.sbin/bsdinstall/scripts/mount

Loading...
View Options

usr.sbin/bsdinstall/scripts/umount

Loading...