New Port: net-mgmt/fastnetmon 1.1.2 - high performance DoS/DDoS load analyzer

[farrokhi]

Summary

New Port: net-mgmt/fastnetmon 1.1.2 - high performance DoS/DDoS load analyzer

[farrokhi]

• previous diff did not contain actual files.

[mat]

Have you run the rc file through devel/rclint ?

net-mgmt/fastnetmon/pkg-plist

1 ↗

(On Diff #8347)

Don't put $FreeBSD$ in there, this is deprecated :-)

5–6 ↗

(On Diff #8347)

If the daemon, runs as fastnetmon:fastnetmon, should these directories belong to that user/group ? In that case, it should be @dir(fastnetmon,fastnetmon,) /var/...

[mat]

Also, it feels like you're using tabs that are 4 spaces wide in the Makefile, they are supposed to be 8.

[farrokhi]

• fixed pkg-plist

[farrokhi]

• Making rclint as much happy as possible

[mat]

net-mgmt/Makefile

60–62 ↗

(On Diff #8352)

I think "fa" is before "fe", no ? could you sort it right ?

net-mgmt/fastnetmon/Makefile

2 ↗

(On Diff #8352)

Oh, you're missing the line with # $FreeBSD$ here

24 ↗

(On Diff #8352)

Can you replace this line with:

WRKSRC_SUBDIR=   src

And replace the ${WRKSRC}/src with ${WRKSRC} below, patch the patch to strip the src/ from the header, see if all still works ?

net-mgmt/fastnetmon/pkg-plist

4–5 ↗

(On Diff #8352)

you're supposed to keep the last argument, even if empty, @dir(fastnetmon,fastnetmon,) at least, that's what everybody's been doing. Maybe @bapt can tell us if it's really needed or not :-)

[farrokhi]

• Fix Makefile sort
• Fix Makefile header

net-mgmt/fastnetmon/Makefile

24 ↗

(On Diff #8352)

You are right. But the problem is it fails to install LICENSE (which is not located under src)

[mat]

net-mgmt/fastnetmon/Makefile

25 ↗

(On Diff #8358)

Ah, yes, well, I had not looked up for usage of WRKSRC 0:-)
Then it's all good, I guess.