net/pathneck:
- Clarify LICENSE
- More Makefile cleanup (reported by danfe@)
Details
Details
- Reviewers
danfe philip bapt mat - Commits
- rP395565: - Clarify LICENSE
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Overall looks fine, but please consider inline comments. And thanks for removing that EOL whitespace, appreciated.
| net/pathneck/Makefile | ||
|---|---|---|
| 16 ↗ | (On Diff #8329) | MAKEFILE above USES still looks a bit weird, do you mind putting it below? (Flipping two knobs.) |
| 21 ↗ | (On Diff #8329) | Once you've added COPYING as LICENSE_FILE, it should be removed from PORTDOCS, otherwise it will be installed twice which is probably not what you want. |
| 28 ↗ | (On Diff #8329) | You might want to check if Makefile.bsd patching is really needed; often (not always! I see += there which can make a difference) it's better to simply pass CC and CFLAGS via MAKE_ARGS. |
Comment Actions
- Still tidying up Makefile
| net/pathneck/Makefile | ||
|---|---|---|
| 28 ↗ | (On Diff #8329) | Overriding CFLAGS when calling make breaks the build. I believe it should be patched. However CC can be safely passed via MAKE_ARGS. |