Page MenuHomeFreeBSD

- Clarify LICENSE
ClosedPublic

Authored by farrokhi on Aug 29 2015, 1:33 PM.

Details

Summary

net/pathneck:

  • Clarify LICENSE
  • More Makefile cleanup (reported by danfe@)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

farrokhi retitled this revision from to - Clarify LICENSE.
farrokhi updated this object.
farrokhi edited the test plan for this revision. (Show Details)
farrokhi added reviewers: philip, mat, bapt.

Overall looks fine, but please consider inline comments. And thanks for removing that EOL whitespace, appreciated.

net/pathneck/Makefile
16 ↗(On Diff #8329)

MAKEFILE above USES still looks a bit weird, do you mind putting it below? (Flipping two knobs.)

21 ↗(On Diff #8329)

Once you've added COPYING as LICENSE_FILE, it should be removed from PORTDOCS, otherwise it will be installed twice which is probably not what you want.

28 ↗(On Diff #8329)

You might want to check if Makefile.bsd patching is really needed; often (not always! I see += there which can make a difference) it's better to simply pass CC and CFLAGS via MAKE_ARGS.

farrokhi marked 2 inline comments as done.
farrokhi edited edge metadata.
  • Still tidying up Makefile
net/pathneck/Makefile
28 ↗(On Diff #8329)

Overriding CFLAGS when calling make breaks the build. I believe it should be patched. However CC can be safely passed via MAKE_ARGS.

mat edited edge metadata.
This revision is now accepted and ready to land.Aug 29 2015, 6:33 PM
This revision was automatically updated to reflect the committed changes.