Page MenuHomeFreeBSD

Update net/rtpproxy to 2.0.0
ClosedPublic

Authored by farrokhi on Aug 28 2015, 7:44 PM.

Details

Summary

net/rtpproxy:

  • update to 2.0.0
  • take maintainership

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

farrokhi retitled this revision from to Update net/rtpproxy to 2.0.0.
farrokhi updated this object.
farrokhi edited the test plan for this revision. (Show Details)
farrokhi added reviewers: philip, bapt, mat.
net/rtpproxy/Makefile
7 ↗(On Diff #8312)

Remove that line, it's the default when USE_GITHUB is defined.

18 ↗(On Diff #8312)

use DISTVERSIONPREFIX=v (and put that line just below the PORTVERSION one. (it'll change the DISTNAME, so you will need to rerun make makesum)

farrokhi marked 2 inline comments as done.
  • Minor cleanups in Makefile
net/rtpproxy/Makefile
8 ↗(On Diff #8322)

The MASTER_SITES line should be removed.

farrokhi marked an inline comment as done.
  • Removed MASTER_SITES definition
net/rtpproxy/Makefile
6 ↗(On Diff #8323)

Missing a tabulation after = here.

16–17 ↗(On Diff #8323)

I think there's a space here after the = sign, it should be a tabulation. portlint should tell you this.

net/rtpproxy/pkg-plist
1 ↗(On Diff #8323)

This should not be in the plist, there should be a USE_RC_SUBR= ${PORTNAME} in the Makefile.

farrokhi marked an inline comment as done.
  • minor Makefile improvements
net/rtpproxy/Makefile
16–17 ↗(On Diff #8323)

They are tabs actually, and portlint didn't complain.

net/rtpproxy/pkg-plist
1 ↗(On Diff #8323)

Actually RC_SUBR comes bundled with the source and is not taken from local patch files. We only improved it using a patch. portlint complains when I use USE_RC_SUBR in this case.

net/rtpproxy/pkg-plist
1 ↗(On Diff #8323)

Mmm, or no, USE_RC_SUBR should only be used when the rc script is in the files directory, sorry for the noise.

net/rtpproxy/Makefile
19 ↗(On Diff #8325)

Ok, so, I told you crap, don't put this here, it's going to assume you have files/PORTNAME.in file.

16–17 ↗(On Diff #8323)

One thing portlint could do, and it did not…

farrokhi marked 3 inline comments as done.
  • removed unnecessary USE_RC_SUBR
mat edited edge metadata.

If it builds, approved

Macro shipit:

This revision is now accepted and ready to land.Aug 29 2015, 8:58 AM

btw, your shell account should be ok now, before committing any ports, do follow the steps for new committers here https://www.freebsd.org/doc/en/articles/committers-guide/conventions.html (if there are you had not performed when you first became a committer)

Also, setup your email forwarding (it's explained in the motd if you ssh on freefall).

This revision was automatically updated to reflect the committed changes.