Differential D35198

sysvsem: Fix a typo.
ClosedPublic
Actions

Authored by dchagin on Fri, May 13, 5:30 PM.

Tags

None

Subscribers

Details

Reviewers

Commits

R10:cb2ae6163174: sysvsem: Fix a typo

Diff Detail

Repository

R10 FreeBSD src repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dchagin created this revision.Fri, May 13, 5:30 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, May 13, 5:30 PM

dchagin requested review of this revision.Fri, May 13, 5:30 PM

Harbormaster completed remote builds in B45567: Diff 105952.Fri, May 13, 5:30 PM

dchagin added a reviewer: jamie.Fri, May 13, 5:51 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.

Wow, that has been there for an embarrassingly long time!

This revision is now accepted and ready to land.Fri, May 13, 8:04 PM

In D35198#797888, @jamie wrote:

Wow, that has been there for an embarrassingly long time!

Well, it's not a bug)) because the rpr cannot be NULL AFAIR, or Im missed something?

In D35198#797902, @dchagin wrote:

In D35198#797888, @jamie wrote:

Wow, that has been there for an embarrassingly long time!

Well, it's not a bug)) because the rpr cannot be NULL AFAIR, or Im missed something?

Actually, it is - perhaps. rpr can be null if the jail is created with sysvsem=disable. But at least it doesn't appear to be fatal, since rpr is never dereferenced (as far as a quick glance suggests) but is only compared to other prison pointers. It might even end up doing the right thing without the null check, but I wouldn't want to count on it.

Closed by commit R10:cb2ae6163174: sysvsem: Fix a typo (authored by dchagin). · Explain WhySat, May 14, 11:08 AM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: R10:cb2ae6163174: sysvsem: Fix a typo.

Revision Contents
Changeset List

Path

Size

sys/

kern/

4 lines

Diff 105992

sys/kern/sysv_sem.c

Loading...