Page MenuHomeFreeBSD

sysvsem: Fix a typo.
ClosedPublic

Authored by dchagin on Fri, May 13, 5:30 PM.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Wow, that has been there for an embarrassingly long time!

This revision is now accepted and ready to land.Fri, May 13, 8:04 PM

Wow, that has been there for an embarrassingly long time!

Well, it's not a bug)) because the rpr cannot be NULL AFAIR, or Im missed something?

Wow, that has been there for an embarrassingly long time!

Well, it's not a bug)) because the rpr cannot be NULL AFAIR, or Im missed something?

Actually, it is - perhaps. rpr can be null if the jail is created with sysvsem=disable. But at least it doesn't appear to be fatal, since rpr is never dereferenced (as far as a quick glance suggests) but is only compared to other prison pointers. It might even end up doing the right thing without the null check, but I wouldn't want to count on it.

This revision was automatically updated to reflect the committed changes.