Page MenuHomeFreeBSD
Differential D3513

Polishing net/pathneck
ClosedPublic
Actions

Authored by farrokhi on Aug 28 2015, 10:00 AM.
Tags
None
Referenced Files
F135883837: D3513.id8284.diff
Thu, Nov 13, 8:33 PM
Unknown Object (File)
Fri, Nov 7, 2:32 PM
Unknown Object (File)
Mon, Nov 3, 7:12 AM
Unknown Object (File)
Mon, Nov 3, 7:12 AM
Unknown Object (File)
Mon, Nov 3, 7:12 AM
Unknown Object (File)
Mon, Nov 3, 7:12 AM
Unknown Object (File)
Mon, Nov 3, 7:12 AM
Unknown Object (File)
Mon, Nov 3, 3:23 AM
View All Files
Subscribers
None

Details

Reviewers
philip
bapt
mat
Commits
rP395548: net/patchneck: Makefile cleanup
Summary
  • Make portlint happy
  • (re)take ownership

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

farrokhi updated this revision to Diff 8281.Aug 28 2015, 10:00 AM
farrokhi retitled this revision from to Polishing net/pathneck.
farrokhi updated this object.
farrokhi edited the test plan for this revision. (Show Details)
farrokhi added reviewers: philip, mat, bapt.
farrokhi updated this revision to Diff 8282.Aug 28 2015, 10:03 AM
  • also remove an stale url from MASTER_SITES
bapt accepted this revision.Aug 28 2015, 10:06 AM
bapt edited edge metadata.
This revision is now accepted and ready to land.Aug 28 2015, 10:06 AM
mat added inline comments.Aug 28 2015, 10:07 AM
net/pathneck/Makefile
30 ↗(On Diff #8282)

You could split up the do-install target above that line and put the documentation installation in a do-install-DOCS-on target so that it is not installed when DOCS is disabled.

farrokhi updated this revision to Diff 8284.Aug 28 2015, 10:14 AM
farrokhi edited edge metadata.
farrokhi marked an inline comment as done.
  • install docs only if DOCS is enabled
This revision now requires review to proceed.Aug 28 2015, 10:14 AM
mat accepted this revision.Aug 28 2015, 10:16 AM
mat edited edge metadata.

When committing, in the svn template, do add:

Approved by:  bapt, mat
Differential Revision: the url to here
This revision is now accepted and ready to land.Aug 28 2015, 10:16 AM
mat added a comment.Aug 28 2015, 10:17 AM

Oh, and do not use arc commit to commit :-)

Closed by commit rP395548: net/patchneck: Makefile cleanup (authored by farrokhi). · Explain WhyAug 29 2015, 11:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
net/
pathneck/
9 lines

Diff 8328

View Options

head/net/pathneck/Makefile

Loading...