Page MenuHomeFreeBSD
Differential D35061

ipmi: Use devclass_find to lookup ipmi devclass in ipmi_unload.
ClosedPublic
Actions

Authored by jhb on Apr 26 2022, 12:10 AM.
Tags
None
Referenced Files
F87060785: D35061.id105417.diff
Fri, Jun 28, 8:09 PM
F87007946: D35061.id105722.diff
Fri, Jun 28, 7:19 AM
Unknown Object (File)
Wed, Jun 26, 8:57 AM
Unknown Object (File)
Sun, Jun 16, 11:14 AM
Unknown Object (File)
Thu, Jun 6, 2:30 AM
Unknown Object (File)
Apr 30 2024, 6:55 PM
Unknown Object (File)
Apr 30 2024, 6:54 PM
Unknown Object (File)
Apr 30 2024, 6:54 PM
View All 25 Files
Subscribers
None

Details

Reviewers
imp
Commits
rGac56d90a49c5: ipmi: Use devclass_find to lookup ipmi devclass in ipmi_unload.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45369
Build 42257: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Apr 26 2022, 12:10 AM
jhb created this revision.
Harbormaster completed remote builds in B45369: Diff 105417.Apr 26 2022, 12:10 AM
jhb added inline comments.Apr 26 2022, 12:11 AM
sys/dev/ipmi/ipmi.c
1073

BTW, this pattern of deleting devices created via BUS_ADD_CHILD in identify routines when unloading a driver that created the devices is not uncommon (there are about 4 or 5 drivers that do it). I wonder if we want to create a helper (devclass_delete_devices or the like) that drivers can use?

This revision was not accepted when it landed; it landed in state Needs Review.May 5 2022, 11:43 PM
Closed by commit rGac56d90a49c5: ipmi: Use devclass_find to lookup ipmi devclass in ipmi_unload. (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rGac56d90a49c5: ipmi: Use devclass_find to lookup ipmi devclass in ipmi_unload..

Revision Contents
Changeset List

PathSize
sys/
dev/
ipmi/
4 lines

Diff 105417

View Options

sys/dev/ipmi/ipmi.c

Loading...