Page MenuHomeFreeBSD

ipmi: Use devclass_find to lookup ipmi devclass in ipmi_unload.
ClosedPublic

Authored by jhb on Apr 26 2022, 12:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 18, 9:06 AM
Unknown Object (File)
Mon, May 18, 9:02 AM
Unknown Object (File)
Fri, May 15, 12:58 AM
Unknown Object (File)
Thu, May 14, 3:51 PM
Unknown Object (File)
Wed, May 13, 10:49 PM
Unknown Object (File)
Wed, May 13, 10:49 PM
Unknown Object (File)
Wed, May 13, 10:42 PM
Unknown Object (File)
Sat, May 9, 6:16 PM
Subscribers
None

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 26 2022, 12:10 AM
jhb created this revision.
sys/dev/ipmi/ipmi.c
1073

BTW, this pattern of deleting devices created via BUS_ADD_CHILD in identify routines when unloading a driver that created the devices is not uncommon (there are about 4 or 5 drivers that do it). I wonder if we want to create a helper (devclass_delete_devices or the like) that drivers can use?

This revision was not accepted when it landed; it landed in state Needs Review.May 5 2022, 11:43 PM
This revision was automatically updated to reflect the committed changes.