Page MenuHomeFreeBSD

firewire: Initialize firewire_devclass in fw_modevent.
ClosedPublic

Authored by jhb on Apr 26 2022, 12:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 7 2024, 4:40 PM
Unknown Object (File)
Jan 14 2024, 9:39 AM
Unknown Object (File)
Jan 12 2024, 1:30 PM
Unknown Object (File)
Dec 23 2023, 3:11 PM
Unknown Object (File)
Dec 2 2023, 11:06 AM
Unknown Object (File)
Aug 30 2023, 8:12 AM
Unknown Object (File)
Aug 7 2023, 11:36 AM
Unknown Object (File)
Jun 16 2023, 3:46 AM
Subscribers
None

Details

Summary

The use of devclass_get_softc() combined with cdev unit numbers is
probably not ideal (probably should be initializing si_drv1 when each
cdev is created instead), but it looks like a bit of a PITA to do, so
just initialize the devclass explicitly instead.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Apr 26 2022, 12:09 AM
jhb created this revision.

Is it time to look at deprecation plans for firewire?

This revision is now accepted and ready to land.Apr 27 2022, 7:10 PM

I thought it was already deprecated which is why I didn't try to fix this "cleanly".