Page MenuHomeFreeBSD

pfilctl: initialize pio_nheads for PFILIOC_LISTHEADS ioctl
Needs ReviewPublic

Authored by rew on Apr 24 2022, 6:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 16, 7:24 AM
Unknown Object (File)
Wed, Aug 12, 10:23 PM
Unknown Object (File)
Mon, Aug 10, 7:47 AM
Unknown Object (File)
Mon, Aug 10, 4:56 AM
Unknown Object (File)
Mon, Aug 10, 3:22 AM
Unknown Object (File)
Sat, Aug 8, 4:07 AM
Unknown Object (File)
Sat, Aug 8, 1:25 AM
Unknown Object (File)
Sun, Aug 2, 1:54 AM
Subscribers

Details

Reviewers
glebius
Summary

When pfilctl hooks is called with no hooks present:

% pfilctl hooks
pfilctl: ioctl(PFILIOC_LISTHEADS): Bad address

If pio_nheads or pio_nhooks is not initialized, pfilioc_listheads()
thinks the caller wants the heads/hooks copied out. However, in this
case, the caller is only expecting the number of heads/hooks returned
and hasn't prepared the buffer that pfilioc_listheads() is trying to
copyout to, causing the bad address error.

Looking at pfilioc_listheads() in sys/net/pfil.c, should the semantics
be to return the number of heads/hooks when either pio_nheads or
pio_nhooks is zero?

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45343
Build 42231: arc lint + arc unit