Page MenuHomeFreeBSD

tzsetup(8): Refactoring
ClosedPublic

Authored by asiciliano on Apr 9 2022, 9:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 1:48 AM
Unknown Object (File)
Tue, Mar 12, 1:48 AM
Unknown Object (File)
Tue, Mar 12, 1:48 AM
Unknown Object (File)
Tue, Mar 12, 1:48 AM
Unknown Object (File)
Tue, Mar 12, 1:38 AM
Unknown Object (File)
Thu, Mar 7, 2:25 PM
Unknown Object (File)
Dec 29 2023, 2:14 AM
Unknown Object (File)
Dec 20 2023, 5:39 AM
Subscribers

Details

Summary

Little refactoring to complete the conversion to bsddialog(3), not functional changes:

  • Delete: remaining code for autosizing using BSDDIALOG_AUTOSIZE.
  • Add: constants to delete magical numbers and avoiding unclear return values.
  • Delete: redundant 'conf.button.defaultno=false', performed by bsddialog_initconf()
  • Add: a new function message_zoneinfo_file() to merge features.
Test Plan

Not functional changes, just some constant and a trivial function.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

other than a small remark, it looks good to me

usr.sbin/tzsetup/tzsetup.c
607

maybe add some parenthesis for libility ?

This revision is now accepted and ready to land.Apr 10 2022, 6:39 AM
asiciliano marked an inline comment as done.
asiciliano retitled this revision from tzsetup(8): (little) Refactoring to tzsetup(8): Refactoring.
asiciliano edited the summary of this revision. (Show Details)
asiciliano edited the test plan for this revision. (Show Details)

Fixed, thanks!

This revision now requires review to proceed.Apr 10 2022, 12:36 PM
usr.sbin/tzsetup/tzsetup.c
607

fixed

This revision is now accepted and ready to land.Apr 11 2022, 6:51 AM