Page MenuHomeFreeBSD

net/qt5-network: fix with LibreSSL 3.5
ClosedPublic

Authored by vishwin on Mar 21 2022, 7:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 8:06 PM
Unknown Object (File)
Dec 13 2024, 12:02 PM
Unknown Object (File)
Dec 9 2024, 5:21 PM
Unknown Object (File)
Dec 7 2024, 4:35 AM
Unknown Object (File)
Nov 25 2024, 3:45 PM
Unknown Object (File)
Nov 24 2024, 6:35 AM
Unknown Object (File)
Nov 24 2024, 1:23 AM
Unknown Object (File)
Nov 22 2024, 8:50 PM
Subscribers

Details

Summary

LibreSSL 3.5, currently security/libressl-devel, opaqued many structs and implemented more functions in line with OpenSSL 1.1

Test Plan

Consumers dogfooded, work as intended

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols__p.h
107

please use parenthesis to make the precedence of || and && explicit.

net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols__p.h
107

Not sure how additional parentheses would help? There are enough of them as is, especially with the !defined(). Kinda sucks that in the latter bit we have to check whether the define exists (because OpenSSL does not define it) otherwise the preprocessor errors out.

net/qt5-network/files/patch-src_network_ssl_qsslsocket__openssl__symbols__p.h
107

Sorry, I missed that you already have them around the (defined(LIBRESSL)...) :)

Ship it as discussed in IRC.

This revision is now accepted and ready to land.May 25 2022, 6:47 PM
This revision now requires review to proceed.May 25 2022, 7:01 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 25 2022, 7:06 PM
This revision was automatically updated to reflect the committed changes.