gpiopower: Fix failure case for attach
ClosedPublic
Actions

Authored by jhibbits on Mar 15 2022, 6:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 9:11 PM

	Unknown Object (File)
	Mon, May 18, 5:36 PM

	Unknown Object (File)
	Mon, May 18, 10:58 AM

	Unknown Object (File)
	Fri, May 15, 10:57 PM

	Unknown Object (File)
	Fri, May 8, 10:41 PM

	Unknown Object (File)
	Wed, Apr 29, 11:08 AM

	Unknown Object (File)
	Wed, Apr 29, 11:04 AM

	Unknown Object (File)
	Mon, Apr 27, 10:29 PM

View All Files

Subscribers

imp

loos

Details

Reviewers

alfredo

Group Reviewers

PowerPC

Commits

rGd7661890efd2: gpiopower: Fix failure case for attach

Summary

We really should be checking the return value of
ofw_gpiobus_parse_gpios_impl, not the value of sc_pins, which isn't
changed on failure.

Reported by: alfredo@

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhibbits created this revision.Mar 15 2022, 6:37 PM

Herald added subscribers: loos, imp. · View Herald TranscriptMar 15 2022, 6:37 PM

jhibbits requested review of this revision.Mar 15 2022, 6:37 PM

Harbormaster completed remote builds in B44786: Diff 103894.Mar 15 2022, 6:37 PM

LGTM. Thanks, it fixes the kernel crashing with QEMU -M ppce500.

This revision is now accepted and ready to land.Mar 15 2022, 7:12 PM

Closed by commit rGd7661890efd2: gpiopower: Fix failure case for attach (authored by jhibbits). · Explain WhyMar 16 2022, 12:11 AM

This revision was automatically updated to reflect the committed changes.

jhibbits added a commit: rGd7661890efd2: gpiopower: Fix failure case for attach.

Revision Contents
Changeset List

Path

Size

sys/

dev/

gpio/

gpiopower.c

3 lines

Diff 103906

View Options

gpiopower: Fix failure case for attachClosedPublicActions