Page MenuHomeFreeBSD

who: add libxo support
Needs ReviewPublic

Authored by swills on Mar 12 2022, 8:51 PM.
Tags
None
Referenced Files
F160998427: D34541.id.diff
Mon, Jun 29, 5:33 PM
Unknown Object (File)
Wed, Jun 24, 1:14 AM
Unknown Object (File)
Sun, Jun 21, 6:27 PM
Unknown Object (File)
Tue, Jun 16, 3:51 AM
Unknown Object (File)
Thu, Jun 4, 2:51 AM
Unknown Object (File)
May 30 2026, 2:45 AM
Unknown Object (File)
May 15 2026, 1:51 PM
Unknown Object (File)
May 15 2026, 3:53 AM
Subscribers

Details

Reviewers
kevans
Summary

Add libxo support to who(1)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 44755
Build 41643: arc lint + arc unit

Event Timeline

swills created this revision.

Thanks, I appreciate it!

(I really need to learn how to use Phabricator 🙃). I'll start with the low hanging fruits, and let someone more knowledgeable handle I18n and more advanced stuff, if needed.

I have attached a file with a couple of minor nits:

  • Simple addition to the man page
  • Addressing the two line comments
  • Removing extra brackets for one-lined ìf statements for consistency with the rest of the file (not really necessary)

I would prefer if (xo_get_style(NULL) == XO_STYLE_TEXT) to if (xo_get_style(NULL) != XO_STYLE_TEXT) everywhere, but this is an old habit of avoiding inverted logic if possible (not really necessary).

usr.bin/who/who.c
168

This should be changed to xo_emit("{:headingstate/%s}", "S ");

171

I believe this should be :headingidle