Page MenuHomeFreeBSD

who: add libxo support
Needs ReviewPublic

Authored by swills on Mar 12 2022, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 6, 9:17 PM
Unknown Object (File)
Sun, Apr 5, 11:42 PM
Unknown Object (File)
Sun, Apr 5, 2:09 PM
Unknown Object (File)
Wed, Apr 1, 5:17 AM
Unknown Object (File)
Mon, Mar 30, 6:39 AM
Unknown Object (File)
Sun, Mar 29, 3:34 AM
Unknown Object (File)
Wed, Mar 25, 4:36 PM
Unknown Object (File)
Wed, Mar 25, 10:04 AM
Subscribers

Details

Reviewers
kevans
Summary

Add libxo support to who(1)

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 44755
Build 41643: arc lint + arc unit

Event Timeline

swills created this revision.

Thanks, I appreciate it!

(I really need to learn how to use Phabricator 🙃). I'll start with the low hanging fruits, and let someone more knowledgeable handle I18n and more advanced stuff, if needed.

I have attached a file with a couple of minor nits:

  • Simple addition to the man page
  • Addressing the two line comments
  • Removing extra brackets for one-lined ìf statements for consistency with the rest of the file (not really necessary)

I would prefer if (xo_get_style(NULL) == XO_STYLE_TEXT) to if (xo_get_style(NULL) != XO_STYLE_TEXT) everywhere, but this is an old habit of avoiding inverted logic if possible (not really necessary).

usr.bin/who/who.c
168

This should be changed to xo_emit("{:headingstate/%s}", "S ");

171

I believe this should be :headingidle