Updated www/seahub and depends to django 3.2.
Details
Details
This builds fine and created seahub testing instance to verify the update. Also
updated a production instance smoothly.
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thank you for your work, only a few review points/notes from my side:
- @sunpoet should be added as a reviewer because some ports of him are also affected.
- IMHO, it woule be a good idea to commit the whole diff once the 2022Q2 is available so we would have a consistency regarding the Django 2.2/3.2 ports. (See also point 2 under Brief description of https://wiki.freebsd.org/Ports/Django/Django32Migration)
- This diff is somehow based on the SVN repository (as it's crossed out) and not on the GIT repository.
| www/py-django-picklefield/Makefile | ||
|---|---|---|
| 4–5 | A bump of PORTREVISION is required due changed dependencies. | |
| 18 | This leads to conflicting RUN_DEPENDS with www/py-django-constance so this port should be switched to Django 3.2 as well. | |
| www/py-django-ranged-response/Makefile | ||
| 2 | A bump of PORTREVISION is required due changed dependencies. | |
| www/py-django-simple-captcha/Makefile | ||
| 4–5 | A bump of PORTREVISION is required due changed dependencies. | |
| www/py-django-statici18n/Makefile | ||
| 4–5 | A bump of PORTREVISION is required due changed dependencies. | |
| www/py-django-webpack-loader/Makefile | ||
| 4–5 | A bump of PORTREVISION is required due changed dependencies. | |
Comment Actions
Hey Kai,
I'll add the revision bump, I left it out because these are only dependency changes, but after rereading that section of the handbook, it does fall under this category.
IMHO, it woule be a good idea to commit the whole diff once the 2022Q2 is available so we would have a consistency regarding the Django 2.2/3.2 ports. (See also point 2 under Brief description of https://wiki.freebsd.org/Ports/Django/Django32Migration)
How do you want to handle this? Will you merge the diff? If so, I can close this review and provide you with this diff.
Comment Actions
There's no need to close this diff. :)
If you can wait with the commit until the 2022Q2 branch is available that would be great. But it's also perfectly fine if you want to commit it as soon as possible.
Comment Actions
Updated diff. I'm not sure how it is doing svn style diff. I'm using arc diff to push it here. I'll leave this open until the branch has been created. Feel free to poke me or commit it if I'm unresponsive.
Comment Actions
Hey Kai,
Who will switch all ports over? or will there be a coordinator for when this should occur?
Comment Actions
Hi Richard,
starting with www/seahub and its dependencies first makes things a bit easier with regard to www/py-djangorestframework, which is used by other ports.
Once this diff lands I'll create a diff which handles the remaining ports that are still using Django 2.2.