fusefs: fix a cached attributes bug during directory rename
ClosedPublic
Actions

Authored by asomers on Feb 22 2022, 5:02 AM.

Details

Reviewers

Commits

rGa9d0655fa413: fusefs: fix a cached attributes bug during directory rename
rG79ec7ebf88ef: fusefs: fix a cached attributes bug during directory rename
rGe8553be9bcfc: fusefs: fix a cached attributes bug during directory rename

Summary

When renaming a directory into a different parent directory, invalidate
the cached attributes of the new parent. Otherwise, stat will show the
wrong st_nlink value.

MFC after: 1 week

Test Plan

test case added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Feb 22 2022, 5:02 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2022, 5:02 AM

asomers requested review of this revision.Feb 22 2022, 5:02 AM

Harbormaster completed remote builds in B44532: Diff 103082.Feb 22 2022, 5:03 AM

It feels so weird reading modern C++ again.

Macro lgtm:

This revision is now accepted and ready to land.Feb 24 2022, 4:58 AM

Hehe, yeah. C++ that's not actually C is surprisingly uncommon. BTW, did you see the related PR at https://github.com/pjd/pjdfstest/pull/58 ?

Closed by commit rGe8553be9bcfc: fusefs: fix a cached attributes bug during directory rename (authored by asomers). · Explain WhyFeb 24 2022, 9:07 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rGe8553be9bcfc: fusefs: fix a cached attributes bug during directory rename.

asomers added a commit: rG79ec7ebf88ef: fusefs: fix a cached attributes bug during directory rename.Mar 9 2022, 5:22 PM

asomers added a commit: rGa9d0655fa413: fusefs: fix a cached attributes bug during directory rename.Aug 20 2022, 12:32 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

fuse_vnops.c

2 lines

tests/

sys/

fs/

fusefs/

rename.cc

38 lines

Diff 103206

View Options

sys/fs/fuse/fuse_vnops.c