Add kern.features when cloudabi support is loaded
ClosedPublic
Actions

Authored by bapt on Aug 19 2015, 3:04 PM.

Details

Reviewers

Commits

rS286924: Add a kern.features.cloudabi64 entry when the module is loaded to helps the

Summary

sysctl -d kern.features.cloudabi
kern.features.cloudabi: CloudABI 32bit support
sysctl -d kern.features.cloudabi64
kern.features.cloudabi64: CloudABI 64bit support

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 8062.Aug 19 2015, 3:04 PM

bapt retitled this revision from to Add kern.features when cloudabi support is loaded.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added a reviewer: ed.

Herald added a subscriber: imp. · View Herald TranscriptAug 19 2015, 3:04 PM

ed added inline comments.Aug 19 2015, 3:10 PM

sys/compat/cloudabi/cloudabi_proc.c
140 ↗	(On Diff #8062)	Please don't do this. :-) The `cloudabi` module on its own does nothing special. It merely means that code that does not depend on the pointer size at all has been loaded. 32-bit support would need to be added through a kernel module `cloudabi32`.

Remove the feature where not needed

Perfectamundo!

This revision is now accepted and ready to land.Aug 19 2015, 3:16 PM

Closed by commit rS286924: Add a kern.features.cloudabi64 entry when the module is loaded to helps the (authored by bapt). · Explain WhyAug 19 2015, 3:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

cloudabi64/

cloudabi64_sysvec.c

2 lines

Diff 8064

View Options

head/sys/amd64/cloudabi64/cloudabi64_sysvec.c

Add kern.features when cloudabi support is loadedClosedPublicActions