Page MenuHomeFreeBSD

bmake: make opt-debug-x-trace broken on Linux
ClosedPublic

Authored by emaste on Feb 9 2022, 1:20 AM.

Details

Summary

It fails during GitHub cross-build actions from Ubuntu 20.04. @sjg reports it is likely an issue with dash.

Failed tests: opt-debug-x-trace
-+ echo 'Counting 1 2 3 4 5 6 7'
++ echo Counting 1 2 3 4 5 6 7

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

emaste requested review of this revision.Feb 9 2022, 1:20 AM
emaste created this revision.
contrib/bmake/unit-tests/Makefile
443

The change I'm about to commit to NetBSD is a bit more involved.
Will take care of this...

Correction, not NetBSD, most BROKEN_TEST stuff goes in bmake, fwiw next version will have:

--- a/bmake/unit-tests/Makefile Tue Feb 08 14:45:13 2022 -0800
+++ b/bmake/unit-tests/Makefile Tue Feb 08 18:45:22 2022 -0800
@@ -446,6 +446,17 @@
 .if ${.MAKE.OS:NDarwin} == ""
 BROKEN_TESTS+= shell-ksh
 .endif
+.if ${.MAKE.OS} == "Linux" && ${.SHELL:tA:T} != "bash"
+.if exists(/etc/os-release)
+distro!= . /etc/os-release && echo $$NAME
+.endif
+# dash fails -x output
+# .SHELL is not bash so may be dash
+# if distro is Ubuntu or we cannot tell, assume the worst
+.if ${distro:U:NUbuntu} == ""
+BROKEN_TESTS+= opt-debug-x-trace
+.endif
+.endif
 .if ${.MAKE.OS} == "SCO_SV"
 BROKEN_TESTS+= \
        opt-debug-graph[23] \

will cleanup at next import

This revision is now accepted and ready to land.Feb 9 2022, 3:16 AM
This revision was automatically updated to reflect the committed changes.