Differential D34216

dtrace: remove unnecessary fflush()
ClosedPublic
Actions

Authored by chs on Feb 8 2022, 11:40 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 16, 8:38 PM

	Unknown Object (File)
	Sat, May 16, 8:38 PM

	Unknown Object (File)
	Sat, May 16, 8:36 PM

	Unknown Object (File)
	Thu, May 7, 6:31 AM

	Unknown Object (File)
	Sun, May 3, 4:31 AM

	Unknown Object (File)
	Tue, Apr 28, 10:32 AM

	Unknown Object (File)
	Sat, Apr 25, 4:18 PM

	Unknown Object (File)
	Tue, Apr 21, 10:32 AM

Subscribers

Details

Reviewers

markj
imp
gnn

Commits

rGf339a3ef6369: dtrace: remove unnecessary fflush()

Summary

This call was added back in the early days of dtrace porting and
no one knows why anymore. The extra flushing causes lots of
unnecessary CPU overhead when a script produces lots of output,
as well as easily losing output because the command can't keep up.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chs created this revision.Feb 8 2022, 11:40 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 8 2022, 11:40 PM

chs requested review of this revision.Feb 8 2022, 11:40 PM

Harbormaster completed remote builds in B44354: Diff 102529.Feb 8 2022, 11:40 PM

chs added a reviewer: markj.Feb 8 2022, 11:41 PM

given all the early returns that *DONT* do this, I have trouble seeing how it would be needed.

imp accepted this revision.Feb 8 2022, 11:51 PM

This revision is now accepted and ready to land.Feb 8 2022, 11:51 PM

markj accepted this revision.Feb 9 2022, 11:53 PM

Closed by commit rGf339a3ef6369: dtrace: remove unnecessary fflush() (authored by chs). · Explain WhyFeb 10 2022, 2:49 AM

This revision was automatically updated to reflect the committed changes.

chs added a commit: rGf339a3ef6369: dtrace: remove unnecessary fflush().

Herald added a reviewer: gnn. · View Herald TranscriptFeb 10 2022, 2:49 AM

Revision Contents
Changeset List

Path

Size

cddl/

contrib/

opensolaris/

lib/

libdtrace/

common/

1 line

Diff 102597

cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c

Loading...