Differential D34176

cfiscsi_done: Free the dummy PDU earlier.
ClosedPublic
Actions

Authored by jhb on Feb 4 2022, 10:44 PM.

Details

Reviewers

mav

Group Reviewers

cam

Commits

rG345739ccaccc: cfiscsi_done: Free the dummy PDU earlier.
rGa3d71fffa786: cfiscsi_done: Free the dummy PDU earlier.

Summary

The dummy PDU needs to be freed before marking task abortion complete
as otherwise cfiscsi_session_terminate_tasks can return and destroy
the session in another thread before the PDU is freed.

Fixes: 2e8d1a55258d iscsi: Allocate a dummy PDU for the internal nexus reset task.
Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 4 2022, 10:44 PM

Herald added a reviewer: cam. · View Herald TranscriptFeb 4 2022, 10:44 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Feb 4 2022, 10:44 PM

Harbormaster completed remote builds in B44295: Diff 102392.Feb 4 2022, 10:44 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 7 2022, 8:55 PM

Closed by commit rGa3d71fffa786: cfiscsi_done: Free the dummy PDU earlier. (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGa3d71fffa786: cfiscsi_done: Free the dummy PDU earlier..

jhb added a commit: rG345739ccaccc: cfiscsi_done: Free the dummy PDU earlier..Apr 29 2022, 11:13 PM

Revision Contents
Changeset List

Path

Size

sys/

cam/

ctl/

ctl_frontend_iscsi.c

2 lines

Diff 102473

View Options

sys/cam/ctl/ctl_frontend_iscsi.c

cfiscsi_done: Free the dummy PDU earlier.ClosedPublicActions