Update superiotool to latest version

[jo_bruelltuete.com]

Summary

Update to 4.17

Test Plan

compiles and runs fine on my 13-stable box.

[jo_bruelltuete.com]

sysutils/superiotool/Makefile

3

i'm not sure about any of the port makefile magic here

6

downloading straight from coreboot's gitiles may be impolite? don't know. we could put the tarball somewhere else.

sysutils/superiotool/files/patch-Makefile

8

the only thing that needs patching in the vendor makefile is this VERSION macro (which we set in our port makefile).
and the manpage path further below.

[avg]

sysutils/superiotool/Makefile

3

Since 4.15 is less than 20121019, then a PORTEPOCH is needed.
At the same time PORTREVISION can be removed or reset to zero.
See 5.2.3 of https://docs.freebsd.org/en/books/porters-handbook/makefiles/

6

Downloading straight from the source is actually the preferred way.
It's that previously they didn't use to have superiotool tarballs / releases.

[avg]

sysutils/superiotool/Makefile

6

At the same time, I am not sure how stable this review.coreboot.org URL is.
I think I misunderstood what it was.
I thought that it was a pre-packaged source archive, but it seems to be dynamically generated from a code repository tag...

Maybe it would be better to use https://coreboot.org/releases/coreboot-4.15.tar.xz and WRKSRC_SUBDIR.
See https://docs.freebsd.org/en/books/porters-handbook/makefiles/#makefile-wrkdir

[jo_bruelltuete.com]

thanks for your suggestions!
i was away for a few days but will update this patch soon.

[pi]

testbuilds@work

[pi]

Have you tried running portlint -AC in the port directory ?

It gives a lot of suggestions for the port Makefile.

[pi]

please update according to portlint -AC or, as a similar tool, portclippy or portfmt.

[pi]

coreboot 4.17 is the latest version, are there any changes to superiotool since 4.15 ?

[pi]

There is some additional blob added to util/superiotool/ite.c with 4.17 for IT8625E

[jo_bruelltuete.com]

ran portlint

[jo_bruelltuete.com]

In D34094#823401, @jo_bruelltuete.com wrote:

ran portlint

$ portlint -C
WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX.
WARN: Makefile: DISTFILES/DISTNAME affects WRKSRC. take caution when changing them.
WARN: /usr/ports/sysutils/superiotool/files/patch-Makefile: patch was not generated using ``make makepatch''.  It is recommended to use ``make makepatch'' when you need to [re-]generate a patch to ensure proper patch format.
0 fatal errors and 3 warnings found.

i dont know what to do about these. makepatch doesn't do anything? distfiles/name is tricky because the distfile is coreboot but the port superiotool, so the auto-magic (as i've understood in the porters handbook) would get the names wrong here.

[avg]

LGTM. Thank you very much!

[jo_bruelltuete.com]

Don't know if @pi wants to take another look... otherwise feel free to commit (i dont have commit permissions).

[jo_bruelltuete.com]

ping @avg -- please click the merge button if good to go.

[jo_bruelltuete.com]

@avg @pi new year new luck. can we commit this?

[pi]

Will use this to also update to 4.18. Tested on some Supermicro board. Looks fine.

[jo_bruelltuete.com]

thank you @pi!