libthr: Use TLS_TCB_* in _tcb_[cd]tor.
ClosedPublic
Actions

Authored by jhb on Jan 25 2022, 12:24 AM.

Tags

None

Referenced Files

	F157310401: D34023.id.diff
	Wed, May 20, 5:32 AM

	F157286317: D34023.id101866.diff
	Wed, May 20, 12:52 AM

	F157264863: D34023.id101916.diff
	Tue, May 19, 8:51 PM

	Unknown Object (File)
	Sun, May 17, 7:20 AM

	Unknown Object (File)
	Sat, May 16, 3:25 PM

	Unknown Object (File)
	Fri, May 15, 10:01 PM

	Unknown Object (File)
	Fri, May 15, 10:01 PM

	Unknown Object (File)
	Fri, May 15, 10:01 PM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rGc4ec1f6efb52: libthr: Use TLS_TCB_* in _tcb_[cd]tor.
rG8de1a8131e42: libthr: Use TLS_TCB_* in _tcb_[cd]tor.

Summary

This matches libc and rtld in using the alignment (TLS_TCB_ALIGN) from
machine/tls.h instead of hardcoding 16.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jan 25 2022, 12:24 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 25 2022, 12:24 AM

jhb requested review of this revision.Jan 25 2022, 12:24 AM

Harbormaster completed remote builds in B44077: Diff 101866.Jan 25 2022, 12:24 AM

I missed this in my earlier machine/tls.h changes. I only changed the size argument to be consistent with rtld/libc that use TLS_TCB_SIZE.

I believe this is fine, although it indeed changes the alignment.

This revision is now accepted and ready to land.Jan 25 2022, 12:37 AM

Closed by commit rG8de1a8131e42: libthr: Use TLS_TCB_* in _tcb_[cd]tor. (authored by jhb). · Explain WhyJan 25 2022, 7:40 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG8de1a8131e42: libthr: Use TLS_TCB_* in _tcb_[cd]tor..

jhb added a commit: rGc4ec1f6efb52: libthr: Use TLS_TCB_* in _tcb_[cd]tor..Apr 29 2022, 11:13 PM

Revision Contents
Changeset List

Path

Size

lib/

libthr/

thread/

thr_ctrdtr.c

4 lines

Diff 101916

View Options

lib/libthr/thread/thr_ctrdtr.c

libthr: Use TLS_TCB_* in _tcb_[cd]tor.ClosedPublicActions