Differential D34008

pfctl: improve error reporting for routehost
ClosedPublic
Actions

Authored by kp on Jan 23 2022, 3:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Dec 29, 6:12 PM

	Unknown Object (File)
	Thu, Dec 11, 2:11 AM

	Unknown Object (File)
	Nov 30 2025, 9:34 PM

	Unknown Object (File)
	Nov 25 2025, 6:07 PM

	Unknown Object (File)
	Nov 15 2025, 9:54 PM

	Unknown Object (File)
	Nov 15 2025, 9:54 PM

	Unknown Object (File)
	Nov 15 2025, 9:54 PM

	Unknown Object (File)
	Nov 15 2025, 8:04 PM

View All 99 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rGb5f6f687a2ee: pfctl: improve error reporting for routehost
rG8ac3a1785343: pfctl: improve error reporting for routehost
rGe68de6694381: pfctl: improve error reporting for routehost

Summary

If an invalid (i.e. overly long) interface name is specified error out
immediately, rather than in expand_rule() so we point at the incorrect
line.

PR: 260958
MFC after: 3 weeks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jan 23 2022, 3:05 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2022, 3:05 PM

kp requested review of this revision.Jan 23 2022, 3:05 PM

Harbormaster completed remote builds in B44057: Diff 101825.Jan 23 2022, 3:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 27 2022, 7:51 AM

Closed by commit rGe68de6694381: pfctl: improve error reporting for routehost (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGe68de6694381: pfctl: improve error reporting for routehost.

kp added a commit: rG8ac3a1785343: pfctl: improve error reporting for routehost.Feb 18 2022, 10:46 AM

kp added a commit: rGb5f6f687a2ee: pfctl: improve error reporting for routehost.

Revision Contents
Changeset List

Path

Size

sbin/

pfctl/

11 lines

Diff 101978

sbin/pfctl/parse.y

Loading...