x11-toolkits/pangomm: update to 2.46.2
AcceptedPublic
Actions

Authored by vishwin on Jan 19 2022, 3:47 AM.

Details

Reviewers

tcberner
fluffy
arrowd

Summary

Converted to meson and removed REFERENCE_PORT vestiges. PORTSCOUT limited to the 2.46 series as 2.48 and later are incompatible with current consumers; the later versions are mainly for GTK 4 consumers that AFAICT do not exist yet.

Test Plan

Passes testport and consumers continue to function properly at runtime. No API/ABI changes.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 43979
Build 40867: arc lint + arc unit

Event Timeline

vishwin created this revision.Jan 19 2022, 3:47 AM

Herald added a subscriber: mat. · View Herald TranscriptJan 19 2022, 3:47 AM

vishwin requested review of this revision.Jan 19 2022, 3:47 AM

Harbormaster completed remote builds in B43979: Diff 101627.Jan 19 2022, 3:47 AM

lgmt

This revision is now accepted and ready to land.Jan 19 2022, 5:44 AM

diizzy added a subscriber: diizzy.Jan 21 2022, 12:12 AM

diizzy added inline comments.

x11-toolkits/pangomm/Makefile
20	If possible please try to fix these issues with upstream as python3 is usually hardcodec for no good reason

Not committing this until after we get graphics/cairomm situated, to avoid having to revision bump this new version.

x11-toolkits/pangomm/Makefile
20	That's a lot of upstreams to go through.

diizzy added inline comments.Jan 21 2022, 7:39 AM

x11-toolkits/pangomm/Makefile
20	Indeed but having at least not to patch build scripts is nice, scripts can usually be fixed by simply using shebangfix. I've submitted fixes upstream for a handful of ports and they've been committed without any fuzz for such issues

vishwin added inline comments.Jan 21 2022, 8:33 AM

x11-toolkits/pangomm/Makefile
20	`shebangfix` doesn't help when `meson.build`s specifically check for a `python3` to execute with the script passed as an argument. Regardless, while it would be nice to not have to make these adjustments on our end, understand that upstream may have their reasons, which may be obsolete now; in which case I welcome anyone to fix them upstream as they are (re-)found. We have bigger issues to deal with, especially when it comes to ensuring stuff actually works as intended on our operating system (compared to that other one most upstreams target)

diizzy added inline comments.Jan 22 2022, 12:32 AM

x11-toolkits/pangomm/Makefile
20	Agreed, I should also clarify that by shebangfix I meant other scripts than meson. In many cases regarding meson it's usually a simple one-liner such as the one below. https://github.com/HOST-Oman/libraqm/pull/146

arrowd added inline comments.May 7 2022, 5:59 PM

x11-toolkits/pangomm/Makefile
20	Meson upstream already have this bug reported: https://github.com/mesonbuild/meson/issues/4608 It might worth adding the link there.

arrowd added inline comments.May 11 2022, 8:17 AM

x11-toolkits/pangomm/Makefile
20	Meson upstream suggested to either follow PEP-394 [1] and install `python3` executable or use a Meson override by the mean of machine file [2]. [1] https://peps.python.org/pep-0394/ [2] https://mesonbuild.com/Machine-files.html