Details

Reviewers

tcberner
fluffy
vishwin

Group Reviewers

portmgr

Commits

R11:14bfb9975e58: graphics/cairomm: Various improvements

Summary

Converted to meson. PORTSCOUT limited to the 1.14 series as 1.16 and later are incompatible with current consumers; the later versions are mainly for GTK 4 consumers that AFAICT do not exist yet.

While here, remove libxml++26 from cairomm_USE_GNOME_IMPL. Very few cairomm consumers also need libxml++26.

Test Plan

Passes testport with all OPTION combinations and consumers continue to function properly. No API/ABI changes, but will most likely have an exp-run to check for explicit libxml++26 consumers. All consumers of this port to be bumped.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vishwin created this revision.Jan 19 2022, 3:41 AM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 19 2022, 3:41 AM

Herald added a subscriber: mat. · View Herald Transcript

vishwin requested review of this revision.Jan 19 2022, 3:41 AM

Harbormaster completed remote builds in B43978: Diff 101626.Jan 19 2022, 3:41 AM

tcberner mentioned this in D33938: devel/glibmm: update to 2.66.2.Jan 19 2022, 5:42 AM

Can we hookup unit tests/test suite?

I agree, please ask for an exp-run .

diizzy added inline comments.Feb 16 2022, 6:36 AM

graphics/cairomm/Makefile
2	Might as well update this to DISTVERSION while at it to follow Porters Handbook more closely
4	Redirects to https
10	Define LICENSE_FILE?
19–20	Do we know which ones?
20	Can we fix this and preferably submit upstream?

vishwin added inline comments.Feb 16 2022, 6:39 AM

graphics/cairomm/Makefile
19–20	All of them. SONAME changed, API and ABI are different, particularly due to GTK 4
20	You can do that yourself, this update is only to catch up on versioning. Good luck

diizzy added inline comments.Feb 16 2022, 6:55 AM

graphics/cairomm/Makefile
19–20	All of them. SONAME changed, API and ABI are different, particularly due to GTK 4
20	You could work on your tone and this isn't necessarily a huge task, see as examples https://cgit.freebsd.org/ports/commit/irc/hexchat/Makefile?id=6a7cf963707c250eaeece3041dd65991cdfe566d https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261845

vishwin added inline comments.Feb 16 2022, 7:01 AM

graphics/cairomm/Makefile
20	And you can work on your expectations on what volunteerism means. You are not my mentor, do not tell me what to do. It's great that you are willing to do those additional cosmetic bits, but my time and effort are and will continue to be extremely limited.

arrowd added inline comments.Feb 16 2022, 10:41 AM

graphics/cairomm/Makefile
20	@vishwin I think, you're overreacting a bit. After all, @diizzy said "can we fix", he never said that you should do it. And I think even mentors can't force you to do that too, as we all are volunteers here. Nevertheless, do not take comments like this as offensive. The discord amongst us is not what we need.