Page MenuHomeFreeBSD
Differential D33782

www/nginx: Fix typo in nginx_prestop
AbandonedPublic
Actions

Authored by jrm on Jan 7 2022, 6:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 5:05 AM
Unknown Object (File)
Oct 29 2023, 10:50 PM
Unknown Object (File)
Jul 27 2023, 5:22 AM
Unknown Object (File)
Dec 29 2022, 3:47 PM
Subscribers
mat

Details

Reviewers
joneum
Summary

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 43769
Build 40657: arc lint + arc unit

Event Timeline

jrm created this revision.Jan 7 2022, 6:14 PM
Herald added a subscriber: mat. · View Herald TranscriptJan 7 2022, 6:14 PM
jrm requested review of this revision.Jan 7 2022, 6:14 PM
Harbormaster completed remote builds in B43769: Diff 101105.Jan 7 2022, 6:14 PM
jrm abandoned this revision.Jan 7 2022, 9:50 PM

Review was ignored, but fix was committed.

joneum added a comment.Jan 7 2022, 9:53 PM

Sorry, have not seen this review.
It's better to write me an eMail directly :-)
Btw: Portrevision is not necessary here in my opinion, because the port has no error when building.

jrm added a comment.Jan 7 2022, 10:00 PM

No problem. As long as it gets fixed.

A PORTREVISION bump is necessary. Users with a package built before this fix will see an error each time they restart nginx, but without the PORTREVISION bump, nothing will tell them they should update their package. In general whenever there is change to the package (but no change to DISTVERSION/PORTVERSION) a PORTREVISION bump is necessary. From section 5.2.3.1 of the Porter's Handbook,

PORTREVISION must be increased each time a change is made to the port that changes the generated package in any way.

Revision Contents
Changeset List

PathSize
www/
nginx/
2 lines
files/
2 lines

Diff 101105

View Options

www/nginx/Makefile

Loading...
View Options

www/nginx/files/nginx.in

Loading...