Page MenuHomeFreeBSD

Make `git format-patch` preferred way of generating patches.
ClosedPublic

Authored by delphij on Dec 28 2021, 1:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 30, 3:14 AM
Unknown Object (File)
Sun, Oct 12, 6:20 AM
Unknown Object (File)
Oct 8 2025, 11:34 PM
Unknown Object (File)
Oct 2 2025, 5:26 AM
Unknown Object (File)
Sep 4 2025, 12:49 AM
Unknown Object (File)
Aug 15 2025, 11:32 AM
Unknown Object (File)
Aug 14 2025, 6:41 PM
Unknown Object (File)
Jul 28 2025, 2:45 PM
Subscribers
None

Details

Summary

git format-patch would generate patchsets that can be applied with
git am and preserve author identity like name and email.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

delphij created this revision.

Looks good to me. My preferred workflow is a little different, but there's nothing at all wrong with this one.

This revision is now accepted and ready to land.Dec 28 2021, 2:00 AM

I might get rid of the git diff > xxx altogether - if the submitter is using git I think we can insist on a git format-patch. The diff -u advice where the submitter is not using git makes sense.

documentation/content/en/articles/problem-reports/_index.adoc
174–180

In general is maybe more typical phrasing?