Differential D33517

ktls: Add a regression test to exercise socket error handling
ClosedPublic
Actions

Authored by markj on Dec 16 2021, 5:27 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 14, 6:41 PM

	Unknown Object (File)
	Mon, May 11, 4:27 AM

	Unknown Object (File)
	Mon, May 11, 4:27 AM

	Unknown Object (File)
	Sun, May 10, 8:39 AM

	Unknown Object (File)
	Fri, May 8, 6:37 PM

	Unknown Object (File)
	Fri, May 8, 3:37 AM

	Unknown Object (File)
	Fri, May 1, 9:37 PM

	Unknown Object (File)
	Mon, Apr 27, 4:17 AM

Subscribers

Details

Reviewers

Commits

rGee5686c614ba: ktls: Add a regression test to exercise socket error handling

Summary

Prior to commit 916c61a5ed37 ("Fix handling of errors from
pru_send(PRUS_NOTREADY)") this test triggered a kernel panic due to an
mbuf double free.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 16 2021, 5:27 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 16 2021, 5:27 PM

markj requested review of this revision.Dec 16 2021, 5:27 PM

Harbormaster completed remote builds in B43425: Diff 100159.Dec 16 2021, 5:27 PM

jhb added inline comments.Dec 16 2021, 6:31 PM

tests/sys/kern/ktls_test.c
1743	Does the test need CBC? I would probably use an AES-GCM cipher (either 1.2 or 1.3) as the "default" cipher for testing things that aren't tied to a specific cipher suite.

Use GCM instead of CBC

Harbormaster completed remote builds in B43426: Diff 100163.Dec 16 2021, 7:02 PM

jhb accepted this revision.Dec 17 2021, 12:48 AM

This revision is now accepted and ready to land.Dec 17 2021, 12:48 AM

Closed by commit rGee5686c614ba: ktls: Add a regression test to exercise socket error handling (authored by markj). · Explain WhyDec 17 2021, 6:13 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGee5686c614ba: ktls: Add a regression test to exercise socket error handling.

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

42 lines

Diff 100219

tests/sys/kern/ktls_test.c

Loading...