Page MenuHomeFreeBSD
Differential D33517

ktls: Add a regression test to exercise socket error handling
ClosedPublic
Actions

Authored by markj on Dec 16 2021, 5:27 PM.
Tags
None
Referenced Files
F131918055: D33517.diff
Sun, Oct 12, 5:12 AM
Unknown Object (File)
Thu, Oct 9, 9:11 PM
Unknown Object (File)
Tue, Oct 7, 9:55 PM
Unknown Object (File)
Fri, Sep 26, 8:36 PM
Unknown Object (File)
Fri, Sep 12, 2:49 PM
Unknown Object (File)
Sep 10 2025, 9:56 AM
Unknown Object (File)
Sep 4 2025, 1:50 AM
Unknown Object (File)
Aug 31 2025, 4:43 AM
View All Files
Subscribers
imp

Details

Reviewers
jhb
Commits
rGee5686c614ba: ktls: Add a regression test to exercise socket error handling
Summary

Prior to commit 916c61a5ed37 ("Fix handling of errors from
pru_send(PRUS_NOTREADY)") this test triggered a kernel panic due to an
mbuf double free.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Dec 16 2021, 5:27 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 16 2021, 5:27 PM
markj requested review of this revision.Dec 16 2021, 5:27 PM
Harbormaster completed remote builds in B43425: Diff 100159.Dec 16 2021, 5:27 PM
jhb added inline comments.Dec 16 2021, 6:31 PM
tests/sys/kern/ktls_test.c
1743

Does the test need CBC? I would probably use an AES-GCM cipher (either 1.2 or 1.3) as the "default" cipher for testing things that aren't tied to a specific cipher suite.

markj updated this revision to Diff 100163.Dec 16 2021, 7:02 PM
markj marked an inline comment as done.

Use GCM instead of CBC

Harbormaster completed remote builds in B43426: Diff 100163.Dec 16 2021, 7:02 PM
jhb accepted this revision.Dec 17 2021, 12:48 AM
This revision is now accepted and ready to land.Dec 17 2021, 12:48 AM
Closed by commit rGee5686c614ba: ktls: Add a regression test to exercise socket error handling (authored by markj). · Explain WhyDec 17 2021, 6:13 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGee5686c614ba: ktls: Add a regression test to exercise socket error handling.

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
42 lines

Diff 100219

View Options

tests/sys/kern/ktls_test.c

Loading...