Page MenuHomeFreeBSD

pci: add missing PCI id of Coffee Lake GPU
ClosedPublic

Authored by corvink on Dec 15 2021, 12:22 PM.
Tags
None
Referenced Files
F99292621: D33460.id100240.diff
Tue, Oct 8, 2:53 AM
Unknown Object (File)
Tue, Sep 24, 11:19 PM
Unknown Object (File)
Fri, Sep 20, 12:39 AM
Unknown Object (File)
Thu, Sep 12, 10:03 PM
Unknown Object (File)
Wed, Sep 11, 9:56 PM
Unknown Object (File)
Wed, Sep 11, 9:56 PM
Unknown Object (File)
Sep 1 2024, 11:07 AM
Unknown Object (File)
Sep 1 2024, 11:07 AM
Subscribers

Details

Summary

The PCI id of an UHD Graphics 630 for Coffee Lake GPUs is missing in
the PCI id list of all Intel GPUs.

You can take a look at https://dgpu-docs.intel.com/devices/hardware-table.html to check that this device id exists.
Or check the linux code: https://github.com/torvalds/linux/commit/d0e062ebb3a44b56a7e672da568334c76f763552

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

@kib @bwidawsk @imp I added you as reviewer because I saw you've added the original file.

Is this stuff really useful? Supposedly it works around BIOS bugs, by reserving stolen memory if BIOS erronously reported it as regular memory.

But it was never properly integrated with the drm bits. And since it was not, I doubt that we need this stuff in the kernel at all.

I have to detect intel_graphics_stolen_base and intel_graphics_stolen_size for GPU passthrough to work properly (see D26209). Instead of duplicating the code of pci_early_quirks.c, I'm reusing these variables. Since one of my devices has this missing device id, GPU passthrough doesn't work on that device.

This revision is now accepted and ready to land.Dec 17 2021, 9:13 PM
This revision was automatically updated to reflect the committed changes.