Page MenuHomeFreeBSD

devel/libcrossguid: Update to latest commit and switch to CMake
ClosedPublic

Authored by diizzy on Dec 13 2021, 2:14 PM.

Details

Summary

The current version is very old and requires a lot of hacking, update to latest commit as the latest release was back in 2017 and switch to CMake.
This update also includes following commit from 3rd party repo for performance:
https://github.com/jhaws1982/crossguid/commit/23a8c007a668413c2e8cbd00984d223ed5ecfe05

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253531

Test Plan

Compile tested on FreeBSD 13.0-STABLE #0 stable/13-n246086-a20c597c6d7 (amd64) (make, make check-plist)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)
...and also tested with our only user multimedia/kodi

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

diizzy created this revision.
diizzy edited the summary of this revision. (Show Details)
devel/libcrossguid/Makefile
4

Just to make sure, the PORTVERSION value doesn't contain the hash, right?

devel/libcrossguid/files/patch-CMakeLists.txt
16

Why do we install straight into ${LOCALBASE}/include, while upstream installs into ${LOCALBASE}/include/libcrossguid?

diizzy added inline comments.
devel/libcrossguid/Makefile
4

I've taken it straight from Porters Handbook and i translates to "libcrossguid-0.2.2.52,1"

devel/libcrossguid/files/patch-CMakeLists.txt
16

That's where users expect to find the headers, it's also inline with several other repos

devel/libcrossguid/files/patch-CMakeLists.txt
16

Still not sure about this. The guid.hpp is quite a generic name, which is probably why the upstream installs it into a subdir.

Can you share these repos you're talking about?

devel/libcrossguid/files/patch-CMakeLists.txt
16

The upstream README provides the following example: https://github.com/graeme-hill/crossguid#creating-guids

If I understand it right, this code won't compile if we install into ${LOCALBASE}/include.

devel/libcrossguid/files/patch-CMakeLists.txt
16

Correct, I assume these are notes for the upcoming version that newer got released

This revision is now accepted and ready to land.Dec 14 2021, 12:30 PM