cam: Initialize wired to false

[imp]

Summary

As part of converting the code to a while loop, the unconditional
initialization of wired to false was lost.

Sponsored by: Netflix

[jrtc27]

sys/cam/cam_periph.c

615

The control flow here is also a bit weird, would make more sense to me as:

while (resource_find_dev(...) == 0 && !wired) {
    if (...) {
        wired = true;
    }
    ...
    if (...) {
        wired = true;
    }
}
if (wired)
    unit = dunit;

[jrtc27]

sys/cam/cam_periph.c

615

Or probably !wired && resource_find_dev(...) == 0 so it doesn't mess with dunit after wired becomes true

[imp]

sys/cam/cam_periph.c

615

Yea, maybe true. Also true that it likely is more likely to introduce a new bug. I'll look at making that structural change in a separate commit that i can take more time to validate so there aren't other hidden dragons... like the fact that we hit continue and reset wired to false which would
break your suggested reordering. Otherwise we would just do 'break' at that point.

[jrtc27]

sys/cam/cam_periph.c

615

I see, initially read it as iterating over property names and thus only one would ever be true... but indeed that's not what it does. Agreed it's not for this diff.

[mjg]

As noted in the mail I don't know what this code is supposed to be doing, so I'm not going to review anything.

However, setting 'wired = false' upfront restores the previously seen behavior and fixes the immediate regression, so I would say this should be committed and any other tinkering should come in later.