Details
Details
- Reviewers
kib - Commits
- rGe511bd1406fa: vfs: fully lockless v_writecount adjustment
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/kern/vfs_default.c | ||
---|---|---|
1322 | Isn't this unsafe? You should ref the vnode before adding 1 to execcount if you ever saw n == 0, and rollback before returning if actually used cmpset was for n < 0. |
sys/kern/vfs_default.c | ||
---|---|---|
1322 | this can only be a problem if someone bogusly adjusts writecount back to 0, but i can make the change if you insist |