archivers/libarchive: Update to 3.5.2

[diizzy]

Summary

PORTVERSION --> DISTVERSION
Use GitHub as primary MASTER_SITE and libarchive.org as fallback
Enable ZSTD by default
Use xz tarball instead of gz (smaller size)
Remove entries for DESC that are already defined in framework
Disable static library
Slightly rearrange Makefile for readability

Changelog: https://github.com/libarchive/libarchive/releases/tag/v3.5.2

Test Plan

Compile and runtime tested on FreeBSD 13.0-STABLE #1 stable/13-n247667-dc9094140c9 (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.2-RELEASE (amd64)
Poudriere testport OK 13.0-RELEASE (i386)

A few users tested via Poudriere on 12.2 (amd64): archivers/libarchive-qt deskutils/pinot , textproc/libgepub , textproc/libextractor , science/v_sim , sysutils/pacman

Following tests in test suite fails on 13-STABLE (amd64): test_sparse_basic and test_fully_sparse_files
Reported upstream https://github.com/libarchive/libarchive/issues/1612 and these also fails using the current version in tree

[arrowd]

LGTM. I'm not sure about removing static library, though. We aren't building it by default anyways, it seems?

[lbartoletti]

In D32988#744835, @arrowd wrote:

LGTM. I'm not sure about removing static library, though. We aren't building it by default anyways, it seems?

Same here. Maybe add an option (enabled by default?)?

[diizzy]

We are building it by default ( lib/libarchive.a ), portmgr prefers to only have shared libs (discussion on irc) and in the past tcb also shared the same opinion. I tested users that might break by this change and they all compile using Poudriere. We've done this in the past for other libraries such as ffmpeg.

[lbartoletti]

In D32988#744846, @diizzy wrote:

We are building it by default ( lib/libarchive.a ), portmgr prefers to only have shared libs (discussion on irc) and in the past tcb also shared the same opinion. I tested users that might break by this change and they all compile using Poudriere. We've done this in the past for other libraries such as ffmpeg.

OK! So ship it :)

[glewis]

Thanks for doing this! No objections from me