Page MenuHomeFreeBSD

ports: Consistently use my new driesm@FreeBSD.org alias
ClosedPublic

Authored by driesm on Nov 8 2021, 6:57 PM.

Details

Summary

Commit message (ingore spaces before the keys like Approved by, phab doesnt allow them to be removed):

ports: Consistently use my new driesm@FreeBSD.org alias

Replace all occurences of driesm.michiels@FreeBSD.org 
with driesm@FreeBSD.org.

Approved by: tbd (mentor)
 Differential Revision: https://reviews.freebsd.org/D32896
Test Plan

git grep seems to not find any more gmails of me, so thats good ;)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

driesm requested review of this revision.Nov 8 2021, 6:57 PM
driesm edited the summary of this revision. (Show Details)

When it comes to the UPDATING file, if that's a recent entry you want to update, I'd say that there is no harm in updating your email there. Please note that in the commit message.

Also, you seem to have an extra space in the suggested commit message before some lines (e.g., Reviewed by).

Please let us know what is your decision regarding the "Contributed by" line and the UPDATING file and update the commit message accordingly. Then I'll be happy to accept this patch :)

net-mgmt/librenms/files/librenms.in
21

I would probably update the email address here instead of removing it.

If you want to remove it anyway, please add a note in the commit message that you are removing a copyright line from this this file.

If you want to update this copyright line, please make sure to reflect that in the commit message (e.g., "Use my @FreeBSD.org alias in the ports tree" instead of "Update MAINTAINER field of my ports to @FreeBSD.org" as you are touching more than just MAINTAINER variables).

0mp requested changes to this revision.Nov 8 2021, 9:11 PM
This revision now requires changes to proceed.Nov 8 2021, 9:11 PM

Note that the ports Git repository requires (or at least very strongly recommends) Subject lines formatted as "topic: description". I would recommend a commit message like:

ports: consistently use my new driesm@FreeBSD.org address

Replace all occurrences of driesm.michiels@gmail.com with driesm@FreeBSD.org.

Incidentally, since "Approved by:" implies review, there's probably no need to include a duplicate "Reviewed by:" line.

Include UPDATING entry, keep contribution statement.

driesm retitled this revision from Update MAINTAINER field of my ports to @FreeBSD.org to ports: Consistently use my new driesm@FreeBSD.org alias.Nov 9 2021, 8:16 AM
driesm edited the summary of this revision. (Show Details)
driesm edited the test plan for this revision. (Show Details)

Looks good to me!

Approved by: philip (mentor)

driesm edited the summary of this revision. (Show Details)

Also, you seem to have an extra space in the suggested commit message before some lines (e.g., Reviewed by).

Phabricator doesnt allow me to put them without spaces, it throws out this error,: should I try to escape them somehow so that its not interpreted as a special field by phab?:

`The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: revisionID.`

Please let us know what is your decision regarding the "Contributed by" line and the UPDATING file and update the commit message accordingly. Then I'll be happy to accept this patch :)

I kept it in the end :)

Last note about the commit message title: some people also use */*: to say that the given patch touches many ports, e.g., */*: Consistently use my new driesm@FreeBSD.org alias. ports is also fine, but I think I don't see it that often. Also, I'm not sure but maybe the commit hook regex requires that there is at least one /. I'm not sure. Anyway, it's a matter of personal style at this point. :)

This revision is now accepted and ready to land.Nov 9 2021, 8:38 AM