Page MenuHomeFreeBSD

lang/pypy: add separate ports for pypy-gdbm, pypy-sqlite3 and pypy-tkinter
ClosedPublic

Authored by dbn on Aug 3 2015, 7:29 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Dec 20, 8:45 PM
Unknown Object (File)
Thu, Dec 5, 5:38 PM
Unknown Object (File)
Nov 11 2024, 2:00 AM
Unknown Object (File)
Sep 30 2024, 4:59 PM
Unknown Object (File)
Sep 30 2024, 4:59 PM
Unknown Object (File)
Sep 30 2024, 4:59 PM
Unknown Object (File)
Sep 30 2024, 4:59 PM
Unknown Object (File)
Sep 30 2024, 4:37 PM
Subscribers

Details

Reviewers
robak
Group Reviewers
Python
Commits
rP395726: lang/pypy: update to 2.6.1
Summary

Add the gdbm port (a la python) for PyPy. Since it is unprecedented having a PyPy dependent port (but with lots of precedents regarding python dependent ports) I thought it would be best to give this a thorough review.

Other than the usual I would like to request review on:

  • The 'ppy' suffix: If/when the python infrastructure grows support for more implementations (such as pypy, pyston, stackless, ironpython and jpython) there could possibly be a need for some implementation specific ports (such as numpy, gdbm, etc). These specific ports (and ports build against the alternative implementations) could be differentiated by having a suffix for the suffix (such as p, s?, s?, i, j respectively).
  • The '26' suffix: now that I think about it I think this version of the PyPy implementation should be dropped as it would conflict with PyPy3 (i.e. I suggest ppy- and ppy3- suffix for lang/pypy and lang/pypy3 respectively).
  • The need for a separate port: This port could possibly be merged into the py-gdbm port (possibly with different Makefile.py or Makefile.ppy ports)? I think it is cleaner to have different ports altogether
  • Integration into Mk/Uses: Any thoughts into how one would go about adding support for this in the Ports Framework?
Test Plan
  • Portlint [done]
  • Port test [done]
  • Poudriere

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dbn retitled this revision from to databases/ppy-gdbm: new PyPy based port.
dbn updated this object.
dbn edited the test plan for this revision. (Show Details)
dbn added reviewers: Python, robak.
dbn set the repository for this revision to rP FreeBSD ports repository.
dbn added a project: Python.
dbn updated this object.

My thoughts on this are:

  • Prefer pypy- as the prefix
    • Would act similarly to pyXY- prefix for python port packages build for Python X.y version
  • If pypy 'versions' are materially same as the same underlying package, then adding support for producing pypy-* versions of said port feels like a good place to start
  • Any pypy- specific framework routines should use/keep as many Python conventions/bits as possible/practical
dbn retitled this revision from databases/ppy-gdbm: new PyPy based port to lang/pypy: add separate ports for pypy-gdbm, pypy-sqlite3 and pypy-tkinter.
This revision was automatically updated to reflect the committed changes.