sockstat: change check for wildcard sockets to avoid historical classes
ClosedPublic
Actions

Authored by karels on Oct 28 2021, 4:55 PM.

Details

Reviewers

tuexen

Commits

rG64acb29b7d96: sockstat: change check for wildcard sockets to avoid historical classes

Summary

sockstat was checking whether a bound address was "host 0", the lowest
host on a network, using inet_lnaof(). This only works for class A/B/C.
However, it isn't useful to bind such an address unless it is really
the unspecified address INADDR_ANY. Change the check to to use that.

Test Plan

tested on system with numerous servers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

karels created this revision.Oct 28 2021, 4:55 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 28 2021, 4:55 PM

karels requested review of this revision.Oct 28 2021, 4:55 PM

Harbormaster completed remote builds in B42420: Diff 97621.Oct 28 2021, 4:55 PM

tuexen accepted this revision.Oct 28 2021, 9:54 PM

This revision is now accepted and ready to land.Oct 28 2021, 9:54 PM

tuexen added inline comments.Oct 28 2021, 9:56 PM

usr.bin/sockstat/sockstat.c
877	Don't you need here (conceptually) `htonl(INADDR_ANY)`?

karels added inline comments.Oct 28 2021, 10:38 PM

usr.bin/sockstat/sockstat.c
877	Conceptually, yes. I see several other instances of comparisons of in_addr's to INADDR_ANY in netstat and others; I had probably just looked at that. I could change it if you prefer; it's not a performance issue.