Page MenuHomeFreeBSD

sockstat: change check for wildcard sockets to avoid historical classes
ClosedPublic

Authored by karels on Oct 28 2021, 4:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 6:05 PM
Unknown Object (File)
Thu, Nov 28, 7:28 AM
Unknown Object (File)
Sun, Nov 24, 3:24 PM
Unknown Object (File)
Nov 10 2024, 5:39 PM
Unknown Object (File)
Oct 22 2024, 2:48 PM
Unknown Object (File)
Oct 7 2024, 2:42 PM
Unknown Object (File)
Sep 24 2024, 2:36 PM
Unknown Object (File)
Sep 23 2024, 7:19 AM
Subscribers

Details

Summary

sockstat was checking whether a bound address was "host 0", the lowest
host on a network, using inet_lnaof(). This only works for class A/B/C.
However, it isn't useful to bind such an address unless it is really
the unspecified address INADDR_ANY. Change the check to to use that.

Test Plan

tested on system with numerous servers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Oct 28 2021, 9:54 PM
usr.bin/sockstat/sockstat.c
877

Don't you need here (conceptually) htonl(INADDR_ANY)?

usr.bin/sockstat/sockstat.c
877

Conceptually, yes. I see several other instances of comparisons of in_addr's to INADDR_ANY in netstat and others; I had probably just looked at that. I could change it if you prefer; it's not a performance issue.